home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

2 rows where issue = 459389883 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

  • shoyer 1
  • HasanAhmadQ7 1

author_association 2

  • CONTRIBUTOR 1
  • MEMBER 1

issue 1

  • groupby on empty DataArray raises StopIteration · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
509518811 https://github.com/pydata/xarray/issues/3037#issuecomment-509518811 https://api.github.com/repos/pydata/xarray/issues/3037 MDEyOklzc3VlQ29tbWVudDUwOTUxODgxMQ== HasanAhmadQ7 32473508 2019-07-09T07:09:05Z 2019-07-09T07:14:44Z CONTRIBUTOR

@shoyer I would like to work on this issue (hopefully my first contribution).

I believe the error should indicate that we cannot groupby an empty group. This would be consistent with the documentation:

``` DataArray.groupby(group, squeeze: bool = True, restore_coord_dims: Optional[bool] = None) Parameters groupstr, DataArray or IndexVariable Array whose unique values should be used to group this array. If a string, must be the name of a variable contained in this dataset. ````

For the groupby class, we can raise an error in case the groupby object instantiation does not specify values to be grouped by. In the case above:

``` ValueError: variable to groupby must not be empty

```

If you find such a solution acceptable, I would create a pull request.

Thank you in advance

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  groupby on empty DataArray raises StopIteration 459389883
505055394 https://github.com/pydata/xarray/issues/3037#issuecomment-505055394 https://api.github.com/repos/pydata/xarray/issues/3037 MDEyOklzc3VlQ29tbWVudDUwNTA1NTM5NA== shoyer 1217238 2019-06-24T15:16:24Z 2019-06-24T15:16:24Z MEMBER

Agreed, this is definitely a bug. I'm not sure if we can define meaningful behavior for this case, but at the least we should raise a better error.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  groupby on empty DataArray raises StopIteration 459389883

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1280.136ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows