home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 457874038 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

  • HasanAhmadQ7 3
  • shoyer 2
  • jfpiolle 1

author_association 3

  • CONTRIBUTOR 3
  • MEMBER 2
  • NONE 1

issue 1

  • open_mfdataset fails on variable attributes with 'list' type · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
517919790 https://github.com/pydata/xarray/issues/3034#issuecomment-517919790 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUxNzkxOTc5MA== HasanAhmadQ7 32473508 2019-08-03T12:08:05Z 2019-08-03T12:08:05Z CONTRIBUTOR

@jfpiolle Thank you very much for the clarification

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038
516776060 https://github.com/pydata/xarray/issues/3034#issuecomment-516776060 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUxNjc3NjA2MA== jfpiolle 11731042 2019-07-31T09:38:02Z 2019-07-31T09:38:02Z NONE

@HasanAhmadQ7 You can have attributes of type list. See for instance this code:

``` from netCDF4 import Dataset import numpy

f = Dataset("example.nc","w") x = f.createDimension("x",3) vlvar = f.createVariable("test_var", numpy.int32, ("x"))

here create an attribute as a list

vlvar.test_attr = ["string a", "string b"]

vlvar[:] = numpy.arange(3) f.close() ```

Having files with different values for the test_attr attribute will cause open_mfdataset to fail.

thanks for addressing this!

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038
515654610 https://github.com/pydata/xarray/issues/3034#issuecomment-515654610 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUxNTY1NDYxMA== HasanAhmadQ7 32473508 2019-07-27T05:41:59Z 2019-07-27T08:15:07Z CONTRIBUTOR

@jfpiolle Would you please share the files, or the code generating them?

As far as I understand we cannot have an attribute of type list. The closest thing I can think of is a variable length type as below

from netCDF4 import Dataset f = Dataset("example.nc","w") vlen_t = f.createVLType(numpy.int32, "phony_vlen") x = f.createDimension("x",3) y = f.createDimension("y",4) vlvar = f.createVariable("phony_vlen_var", vlen_t, ("y","x")) data =[] for n in range(0, len(x)*len(y)): data.append(numpy.arange(random.randint(1,10),dtype="int32")) data = numpy.reshape(data,(len(y),len(x))) vlvar[:] = data f.close() Using files generated this way, I did not get an error using mf_dataset.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038
514054766 https://github.com/pydata/xarray/issues/3034#issuecomment-514054766 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUxNDA1NDc2Ng== shoyer 1217238 2019-07-23T05:01:49Z 2019-07-23T05:01:49Z MEMBER

Thanks @HasanAhmadQ7, that would be fantastic !

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038
514049445 https://github.com/pydata/xarray/issues/3034#issuecomment-514049445 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUxNDA0OTQ0NQ== HasanAhmadQ7 32473508 2019-07-23T04:28:58Z 2019-07-23T04:28:58Z CONTRIBUTOR

I will handle this issue this Saturday if no one else handle it by then.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038
504034289 https://github.com/pydata/xarray/issues/3034#issuecomment-504034289 https://api.github.com/repos/pydata/xarray/issues/3034 MDEyOklzc3VlQ29tbWVudDUwNDAzNDI4OQ== shoyer 1217238 2019-06-20T13:52:29Z 2019-06-20T13:52:29Z MEMBER

We could probably fix this by adding another case to equivalent for lists, e.g,. python elif isinstance(first, list) or isinstance(second, list): # verify both first and second are lists of the same length with the same elements # (by calling equivalent() on all elements)

Any interest in putting together a pull request for this? See http://xarray.pydata.org/en/stable/contributing.html

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  open_mfdataset fails on variable attributes with 'list' type 457874038

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1523.228ms · About: xarray-datasette