issue_comments

Table actions

5 rows where issue = 456971151 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Add "errors" keyword argument to drop() and drop_dims() (#2994) · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
504078924 https://github.com/pydata/xarray/pull/3028#issuecomment-504078924 https://api.github.com/repos/pydata/xarray/issues/3028 MDEyOklzc3VlQ29tbWVudDUwNDA3ODkyNA== andrew-c-ross 5852283 2019-06-20T15:46:59Z 2019-06-20T15:46:59Z CONTRIBUTOR

Sounds great. Thanks for making this a smooth and well documented process for new contributors 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add "errors" keyword argument to drop() and drop_dims() (#2994) 456971151
504069867 https://github.com/pydata/xarray/pull/3028#issuecomment-504069867 https://api.github.com/repos/pydata/xarray/issues/3028 MDEyOklzc3VlQ29tbWVudDUwNDA2OTg2Nw== shoyer 1217238 2019-06-20T15:24:19Z 2019-06-20T15:24:19Z MEMBER

OK, I'm going to go ahead and merge after tests pass!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add "errors" keyword argument to drop() and drop_dims() (#2994) 456971151
503553184 https://github.com/pydata/xarray/pull/3028#issuecomment-503553184 https://api.github.com/repos/pydata/xarray/issues/3028 MDEyOklzc3VlQ29tbWVudDUwMzU1MzE4NA== andrew-c-ross 5852283 2019-06-19T13:08:41Z 2019-06-19T13:08:41Z CONTRIBUTOR

I have to say as someone who is probably an average user, inconsistencies between related projects, like xarray/pandas or matplotlib/seaborn, drive me nuts. But I also agree that missing= is more descriptive, and if we were starting from scratch I would totally support that. So I will defer to the maintainers here. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add "errors" keyword argument to drop() and drop_dims() (#2994) 456971151
503241583 https://github.com/pydata/xarray/pull/3028#issuecomment-503241583 https://api.github.com/repos/pydata/xarray/issues/3028 MDEyOklzc3VlQ29tbWVudDUwMzI0MTU4Mw== max-sixty 5635139 2019-06-18T17:49:03Z 2019-06-18T17:49:03Z MEMBER

One design question: should we stick with errors='ignore' like pandas, or would it be better to use a more self-descriptive argument name like missing='ignore'/missing='raise'?

I'm ambivalent. I prefer the missing=, but I'm more 'in it' than the average user, who would probably prefer consistency. If people / @shoyer vote that missing= is materially better, let's change

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add "errors" keyword argument to drop() and drop_dims() (#2994) 456971151
503189754 https://github.com/pydata/xarray/pull/3028#issuecomment-503189754 https://api.github.com/repos/pydata/xarray/issues/3028 MDEyOklzc3VlQ29tbWVudDUwMzE4OTc1NA== shoyer 1217238 2019-06-18T15:33:50Z 2019-06-18T15:33:50Z MEMBER

This looks great, thank you!

One design question: should we stick with errors='ignore' like pandas, or would it be better to use a more self-descriptive argument name like missing='ignore'/missing='raise'?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add "errors" keyword argument to drop() and drop_dims() (#2994) 456971151

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);