issue_comments

Table actions

5 rows where issue = 456490234 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Check types in travis · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
502949926 https://github.com/pydata/xarray/pull/3024#issuecomment-502949926 https://api.github.com/repos/pydata/xarray/issues/3024 MDEyOklzc3VlQ29tbWVudDUwMjk0OTkyNg== shoyer 1217238 2019-06-18T05:12:55Z 2019-06-18T05:12:55Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check types in travis 456490234
502927765 https://github.com/pydata/xarray/pull/3024#issuecomment-502927765 https://api.github.com/repos/pydata/xarray/issues/3024 MDEyOklzc3VlQ29tbWVudDUwMjkyNzc2NQ== max-sixty 5635139 2019-06-18T03:08:28Z 2019-06-18T03:08:28Z MEMBER

Great, moved to allow_failures - could someone give this a final check (or feel free to merge directly)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check types in travis 456490234
502869551 https://github.com/pydata/xarray/pull/3024#issuecomment-502869551 https://api.github.com/repos/pydata/xarray/issues/3024 MDEyOklzc3VlQ29tbWVudDUwMjg2OTU1MQ== shoyer 1217238 2019-06-17T22:09:17Z 2019-06-17T22:09:17Z MEMBER

Sure, sounds great to add this as an allowed failure for now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check types in travis 456490234
502771542 https://github.com/pydata/xarray/pull/3024#issuecomment-502771542 https://api.github.com/repos/pydata/xarray/issues/3024 MDEyOklzc3VlQ29tbWVudDUwMjc3MTU0Mg== max-sixty 5635139 2019-06-17T17:12:32Z 2019-06-17T17:12:32Z MEMBER

pep8speaks doesn't run mypy yet, unfortunately.

Shall I add to allow_failures and we can see whether it's failing too often for normal PRs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check types in travis 456490234
502742024 https://github.com/pydata/xarray/pull/3024#issuecomment-502742024 https://api.github.com/repos/pydata/xarray/issues/3024 MDEyOklzc3VlQ29tbWVudDUwMjc0MjAyNA== shoyer 1217238 2019-06-17T15:52:14Z 2019-06-17T15:52:14Z MEMBER

My original reason for not enabling this was to impose the burden of hunting down type errors on Travis-CI. But maybe we can figure out how to run mypy with pep8speaks?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check types in travis 456490234

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);