issue_comments

Table actions

8 rows where issue = 454168102 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Xarray test suite failing with dask-master · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
502745283 https://github.com/pydata/xarray/issues/3009#issuecomment-502745283 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjc0NTI4Mw== pentschev 4398246 2019-06-17T16:00:27Z 2019-06-17T16:00:51Z CONTRIBUTOR

Indeed it was. Regardless, https://github.com/dask/dask/pull/4954 will solve that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502731388 https://github.com/pydata/xarray/issues/3009#issuecomment-502731388 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjczMTM4OA== shoyer 1217238 2019-06-17T15:27:25Z 2019-06-17T15:27:25Z MEMBER

We're down to 1 failing test!

```python # Invalid cases if not use_dask or LooseVersion(dask.version) > LooseVersion('0.17.4'): with pytest.raises(TypeError):

          xr.dot(da_a, dims='a', invalid=None)

E Failed: DID NOT RAISE <class 'TypeError'> ```

I think this was an intentional change -- see https://github.com/dask/dask/pull/4914.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502721965 https://github.com/pydata/xarray/issues/3009#issuecomment-502721965 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjcyMTk2NQ== shoyer 1217238 2019-06-17T15:04:40Z 2019-06-17T15:04:40Z MEMBER

Xarray definitely had a bug with ImplicitToExplicitIndexingAdapter. See https://github.com/pydata/xarray/pull/3027 for the fix.

Unfortunately, this triggers new failures from inside dask's blockwise_meta helper: ```

  return meta.astype(dtype)

E AttributeError: 'ImplicitToExplicitIndexingAdapter' object has no attribute 'astype' ```

The bigger issue this surfaces is that I'm not sure whether ImplicitToExplicitIndexingAdapter (and xarray's other custom array types used for data loading) should be in meta or not. These array types overload indexing, but they don't implement the rest of NumPy's ndarray API. So it's a little strange to see them in meta (and of course methods like astype don't work on them).

On the other hand, they do need to be preserved rather than always cast to NumPy arrays. Otherwise repeated indexing like x[i][j] doesn't get optimized by dask, which turns out to be a really important optimization.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502719087 https://github.com/pydata/xarray/issues/3009#issuecomment-502719087 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjcxOTA4Nw== max-sixty 5635139 2019-06-17T14:58:06Z 2019-06-17T14:58:06Z MEMBER

We're down to 1 failing test!

```python # Invalid cases if not use_dask or LooseVersion(dask.version) > LooseVersion('0.17.4'): with pytest.raises(TypeError):

          xr.dot(da_a, dims='a', invalid=None)

E Failed: DID NOT RAISE <class 'TypeError'> ```

https://travis-ci.org/pydata/xarray/jobs/546491564

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502550448 https://github.com/pydata/xarray/issues/3009#issuecomment-502550448 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjU1MDQ0OA== mrocklin 306380 2019-06-17T06:24:12Z 2019-06-17T06:24:12Z MEMBER

OK, reproduced. I'll take a look later today. Thanks for pointing me to that @max-sixty .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502492315 https://github.com/pydata/xarray/issues/3009#issuecomment-502492315 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjQ5MjMxNQ== max-sixty 5635139 2019-06-16T22:49:01Z 2019-06-16T22:49:01Z MEMBER

@mrocklin unfortunately I think the tests are still failing with dask master: https://travis-ci.org/pydata/xarray/jobs/546491564

I'm not that familiar with this part of the codebase; though let me know if I can be helpful at all

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
502432894 https://github.com/pydata/xarray/issues/3009#issuecomment-502432894 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMjQzMjg5NA== mrocklin 306380 2019-06-16T08:42:36Z 2019-06-16T08:42:36Z MEMBER

I believe that this is now resolved. Please let me know 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102
501707221 https://github.com/pydata/xarray/issues/3009#issuecomment-501707221 https://api.github.com/repos/pydata/xarray/issues/3009 MDEyOklzc3VlQ29tbWVudDUwMTcwNzIyMQ== mrocklin 306380 2019-06-13T13:40:10Z 2019-06-13T13:40:10Z MEMBER

cc @pentschev 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray test suite failing with dask-master 454168102

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);