issue_comments

Table actions

3 rows where issue = 448312915 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Remove deprecated pytest.config usages · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
495826896 https://github.com/pydata/xarray/pull/2988#issuecomment-495826896 https://api.github.com/repos/pydata/xarray/issues/2988 MDEyOklzc3VlQ29tbWVudDQ5NTgyNjg5Ng== max-sixty 5635139 2019-05-25T02:01:27Z 2019-05-25T02:01:27Z MEMBER

OK great; I'll merge

We don't test-the-tests so anyone who encounters any problems: post here and I'll prioritize

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove deprecated pytest.config usages 448312915
495820725 https://github.com/pydata/xarray/pull/2988#issuecomment-495820725 https://api.github.com/repos/pydata/xarray/issues/2988 MDEyOklzc3VlQ29tbWVudDQ5NTgyMDcyNQ== shoyer 1217238 2019-05-25T00:44:23Z 2019-05-25T00:44:23Z MEMBER

This looks fine to me. I don't think it's important to retain the same command for running flakey tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove deprecated pytest.config usages 448312915
495768298 https://github.com/pydata/xarray/pull/2988#issuecomment-495768298 https://api.github.com/repos/pydata/xarray/issues/2988 MDEyOklzc3VlQ29tbWVudDQ5NTc2ODI5OA== max-sixty 5635139 2019-05-24T19:48:37Z 2019-05-24T19:48:37Z MEMBER

After some testing, this doesn't change behavior. As before, it mostly works:

  • Running pytest --pyargs xarray to test against an installed version doesn't allow passing command line options such as --run-flaky (either with the existing or proposed version)
  • With the proposed version you can pass -m flaky, because these are now marks
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove deprecated pytest.config usages 448312915

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);