issue_comments

Table actions

3 rows where issue = 441088452 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • `groupby` does not correctly handle non-dimensional coordinate · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
846304424 https://github.com/pydata/xarray/issues/2944#issuecomment-846304424 https://api.github.com/repos/pydata/xarray/issues/2944 MDEyOklzc3VlQ29tbWVudDg0NjMwNDQyNA== fujiisoup 6815844 2021-05-21T23:12:21Z 2021-05-21T23:12:21Z MEMBER

Closed as the discussions can be continued in #5361 .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `groupby` does not correctly handle non-dimensional coordinate 441088452
540209789 https://github.com/pydata/xarray/issues/2944#issuecomment-540209789 https://api.github.com/repos/pydata/xarray/issues/2944 MDEyOklzc3VlQ29tbWVudDU0MDIwOTc4OQ== max-sixty 5635139 2019-10-09T21:32:05Z 2019-10-09T21:32:05Z MEMBER

I had generally thought that we didn't want to keep non-dim coords along the group by i.e. if you want to keep them, put them as variables.

I'm also think it would be difficult to resolve issues like whether or not to keep coords based on their type in a way that wasn't surprising (though I guess we have to do it for data vars, even if we don't hit it often).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `groupby` does not correctly handle non-dimensional coordinate 441088452
540182562 https://github.com/pydata/xarray/issues/2944#issuecomment-540182562 https://api.github.com/repos/pydata/xarray/issues/2944 MDEyOklzc3VlQ29tbWVudDU0MDE4MjU2Mg== dcherian 2448579 2019-10-09T20:36:55Z 2019-10-09T20:36:55Z MEMBER

So that has been fixed on master somehow but

python da = xr.DataArray(np.arange(12).reshape(3, 4), dims=['x', 'y'], coords={'x': [0, 1, 1], 'x2': ('x', ['a', 'b', 'c']), 'x3': ('x', [4, 5, 6])}) da.groupby("x").mean("x") gives <xarray.DataArray (x: 2, y: 4)> array([[0., 1., 2., 3.], [6., 7., 8., 9.]]) Coordinates: * x (x) int64 0 1 Dimensions without coordinates: y

i.e coordinate x3 has been dropped though the mean along x is meaningful. This is consistent with the behaviour of reduce e.g. ``` python da.mean("x")

<xarray.DataArray (y: 4)> array([4., 5., 6., 7.]) Dimensions without coordinates: y ```

What would be the best way to implement reductions for non-dim coords? Add a reduce_coords kwarg?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `groupby` does not correctly handle non-dimensional coordinate 441088452

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);