issue_comments

Table actions

7 rows where issue = 440900618 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Fix rolling operation with dask and bottleneck · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
506997136 https://github.com/pydata/xarray/pull/2942#issuecomment-506997136 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwNjk5NzEzNg== shoyer 1217238 2019-06-30T00:34:57Z 2019-06-30T00:34:57Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
504774733 https://github.com/pydata/xarray/pull/2942#issuecomment-504774733 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwNDc3NDczMw== shoyer 1217238 2019-06-23T18:14:07Z 2019-06-23T18:14:07Z MEMBER

@fujiisoup yes, indeed, that's a much better temporary fix! See https://github.com/pydata/xarray/pull/3040.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
504302684 https://github.com/pydata/xarray/pull/2942#issuecomment-504302684 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwNDMwMjY4NA== fujiisoup 6815844 2019-06-21T06:07:39Z 2019-06-21T06:07:39Z MEMBER

Hi. Sorry for my slow responce...

lf I understood correctly, it happens with dask and bottleneck. So, probably we can skip using bottleneck if the backend array is dask array?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
504058696 https://github.com/pydata/xarray/pull/2942#issuecomment-504058696 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwNDA1ODY5Ng== shoyer 1217238 2019-06-20T14:56:11Z 2019-06-20T14:56:11Z MEMBER

I did a little more looking into this, and I unfortunately I think the necessary fix is a little more involved. For now, I think we should disable rolling() with dask arrays to avoid computing incorrect results: https://github.com/pydata/xarray/issues/2940#issuecomment-504058279

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
503171241 https://github.com/pydata/xarray/pull/2942#issuecomment-503171241 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwMzE3MTI0MQ== zbarry 4762711 2019-06-18T14:51:06Z 2019-06-19T17:33:21Z NONE

Hey just wanted to chime in and say it appears that commit https://github.com/fujiisoup/xarray/commit/098daf3020e817d03a17a81963ad3cf831fbb48c is still losing chunking for me as far as I can tell when running it with dask distributed / dask jobqueue. I can do some extended testing & look further into this if people have some suggestions for how to go about it.

@fujiisoup 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
502324471 https://github.com/pydata/xarray/pull/2942#issuecomment-502324471 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDUwMjMyNDQ3MQ== max-sixty 5635139 2019-06-15T01:39:41Z 2019-06-18T17:47:04Z MEMBER

~@fujiisoup I mistakenly removed the dask-master tests (I moved the dask test from the test matrix to the ignored failures, rather than adding it to ignored failures)~

~Here's a tiny patch which restores it, if you want to add this to your PR:~

EDIT: moved to separate PR

```patch

diff --git a/.travis.yml b/.travis.yml index 913c5e1c..8249b134 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,12 +19,12 @@ matrix: - env: CONDA_ENV=py36-pandas-dev - env: CONDA_ENV=py36-rasterio - env: CONDA_ENV=py36-zarr-dev + - env: CONDA_ENV=py36-dask-dev - env: CONDA_ENV=docs - env: CONDA_ENV=lint - env: CONDA_ENV=py36-hypothesis

allow_failures: - - env: CONDA_ENV=py36-dask-dev - env: - CONDA_ENV=py36 - EXTRA_FLAGS="--run-flaky --run-network-tests" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618
490128835 https://github.com/pydata/xarray/pull/2942#issuecomment-490128835 https://api.github.com/repos/pydata/xarray/issues/2942 MDEyOklzc3VlQ29tbWVudDQ5MDEyODgzNQ== shoyer 1217238 2019-05-07T15:28:12Z 2019-05-07T15:28:12Z MEMBER

@fujiisoup, thanks for looking into this! Unfortunately these tests still seem to still be failing on Travis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix rolling operation with dask and bottleneck 440900618

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);