issue_comments

Table actions

8 rows where issue = 440254754 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Contiguous store with unlim dim bug fix · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
498835498 https://github.com/pydata/xarray/pull/2941#issuecomment-498835498 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ5ODgzNTQ5OA== dcherian 2448579 2019-06-04T20:41:44Z 2019-06-04T20:41:44Z MEMBER

=). Thanks @jmccreight. Merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
489267577 https://github.com/pydata/xarray/pull/2941#issuecomment-489267577 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ4OTI2NzU3Nw== pep8speaks 24736507 2019-05-03T23:13:41Z 2019-06-04T16:16:10Z NONE

Hello @jmccreight! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-06-04 16:16:07 UTC
 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 1,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
494118496 https://github.com/pydata/xarray/pull/2941#issuecomment-494118496 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ5NDExODQ5Ng== jmccreight 12465248 2019-05-20T19:24:41Z 2019-05-20T19:24:41Z CONTRIBUTOR

🎊 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
494079089 https://github.com/pydata/xarray/pull/2941#issuecomment-494079089 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ5NDA3OTA4OQ== dcherian 2448579 2019-05-20T17:27:28Z 2019-05-20T17:27:28Z MEMBER

The failures seem unrelated. can you merge master and remove the warning?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
489828927 https://github.com/pydata/xarray/pull/2941#issuecomment-489828927 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ4OTgyODkyNw== jmccreight 12465248 2019-05-06T23:56:01Z 2019-05-06T23:56:01Z CONTRIBUTOR

There were easy patterns to follow for this, so I just went for it. @dcherian Are the failures fixable? I'm not sure what to make of them. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
489372622 https://github.com/pydata/xarray/pull/2941#issuecomment-489372622 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ4OTM3MjYyMg== dcherian 2448579 2019-05-04T23:15:22Z 2019-05-04T23:15:22Z MEMBER

Thanks @jmccreight. That was quick.

I think we can do without the warning but we should wait till someone else chimes in. Otherwise, this looks right to me but I don't know this bit of the code too well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
489328948 https://github.com/pydata/xarray/pull/2941#issuecomment-489328948 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ4OTMyODk0OA== jmccreight 12465248 2019-05-04T13:51:22Z 2019-05-04T13:51:22Z CONTRIBUTOR

I should add that changing the encoding on the variable itself was not "an easy detail". The basic thing I tried was unsuccessful, so if this is desired some more work is needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754
489268054 https://github.com/pydata/xarray/pull/2941#issuecomment-489268054 https://api.github.com/repos/pydata/xarray/issues/2941 MDEyOklzc3VlQ29tbWVudDQ4OTI2ODA1NA== jmccreight 12465248 2019-05-03T23:16:21Z 2019-05-03T23:16:21Z CONTRIBUTOR

I guess the additional documentation would go here. http://xarray.pydata.org/en/stable/io.html#writing-encoded-data If we decide to keep the "gnarly" warning message, we should probably do a bit of explaination here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Contiguous store with unlim dim bug fix 440254754

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);