issue_comments

Table actions

5 rows where issue = 437418337 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • [WIP] Custom fill value for reindex, align, and merge operations · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
489375736 https://github.com/pydata/xarray/pull/2920#issuecomment-489375736 https://api.github.com/repos/pydata/xarray/issues/2920 MDEyOklzc3VlQ29tbWVudDQ4OTM3NTczNg== shoyer 1217238 2019-05-05T00:21:23Z 2019-05-05T00:21:23Z MEMBER

thanks @zdgriffith!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Custom fill value for reindex, align, and merge operations 437418337
488870476 https://github.com/pydata/xarray/pull/2920#issuecomment-488870476 https://api.github.com/repos/pydata/xarray/issues/2920 MDEyOklzc3VlQ29tbWVudDQ4ODg3MDQ3Ng== dcherian 2448579 2019-05-02T23:42:26Z 2019-05-02T23:42:26Z MEMBER

+1 for a line in the docs, I don't think an example is needed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Custom fill value for reindex, align, and merge operations 437418337
488850688 https://github.com/pydata/xarray/pull/2920#issuecomment-488850688 https://api.github.com/repos/pydata/xarray/issues/2920 MDEyOklzc3VlQ29tbWVudDQ4ODg1MDY4OA== shoyer 1217238 2019-05-02T22:11:20Z 2019-05-02T22:11:20Z MEMBER

Would edits to the docs be in-scope for this PR?

Up to you. Would be happy to include any edits you think are appropriate but they aren't required. The API docs are the canonical reference for various function options but if you think there are good places to mention this option in the narrative docs that would also be welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Custom fill value for reindex, align, and merge operations 437418337
488847303 https://github.com/pydata/xarray/pull/2920#issuecomment-488847303 https://api.github.com/repos/pydata/xarray/issues/2920 MDEyOklzc3VlQ29tbWVudDQ4ODg0NzMwMw== zdgriffith 17169544 2019-05-02T21:58:13Z 2019-05-02T21:58:13Z CONTRIBUTOR

Thanks for the review @shoyer! Would edits to the docs be in-scope for this PR? For example where fill values are mentioned in http://xarray.pydata.org/en/latest/indexing.html#align-and-reindex.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Custom fill value for reindex, align, and merge operations 437418337
486855452 https://github.com/pydata/xarray/pull/2920#issuecomment-486855452 https://api.github.com/repos/pydata/xarray/issues/2920 MDEyOklzc3VlQ29tbWVudDQ4Njg1NTQ1Mg== pep8speaks 24736507 2019-04-25T22:08:20Z 2019-05-02T21:54:47Z NONE

Hello @zdgriffith! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-05-02 21:54:47 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Custom fill value for reindex, align, and merge operations 437418337

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);