issue_comments

Table actions

7 rows where issue = 436669736 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • xr.open_dataset no groups info · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511155810 https://github.com/pydata/xarray/issues/2916#issuecomment-511155810 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDUxMTE1NTgxMA== dcherian 2448579 2019-07-13T21:42:34Z 2019-07-13T21:42:34Z MEMBER

Actually I don't think that is a good idea any more. A Dataset represents a single group so it's weird to print group info under a dataset repr

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
511153086 https://github.com/pydata/xarray/issues/2916#issuecomment-511153086 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDUxMTE1MzA4Ng== zdgriffith 17169544 2019-07-13T20:56:45Z 2019-07-13T20:56:45Z CONTRIBUTOR

I work with netCDF groups regularly and am interested in this issue. I agree with @dcherian that having groups added to the Dataset repr when a netCDF file with groups is loaded would be helpful (regardless of if the root group is empty or not) and pretty unobtrusive.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
489144594 https://github.com/pydata/xarray/issues/2916#issuecomment-489144594 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDQ4OTE0NDU5NA== dcherian 2448579 2019-05-03T15:54:28Z 2019-05-03T15:54:28Z MEMBER

@shoyer What about adding groups to just the repr? That way the user knows there are group names they can pass to open_dataset

python <xarray.Dataset> Dimensions: () Groups: Audio Data variables: *empty*

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
486811770 https://github.com/pydata/xarray/issues/2916#issuecomment-486811770 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDQ4NjgxMTc3MA== shoyer 1217238 2019-04-25T19:43:08Z 2019-04-25T19:43:08Z MEMBER

see https://github.com/pydata/xarray/issues/1092 for discussion about Dataset groups in xarray's data model

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
486809593 https://github.com/pydata/xarray/issues/2916#issuecomment-486809593 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDQ4NjgwOTU5Mw== ThetomekK 6866371 2019-04-25T19:36:06Z 2019-04-25T19:36:06Z NONE

@shoyer In my opinion, if xarray offers optional groups in to_netcdf() method, it should consequently provide a. groups attribute, if a.nc file contains groups and is read without group selection. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
486422402 https://github.com/pydata/xarray/issues/2916#issuecomment-486422402 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDQ4NjQyMjQwMg== shoyer 1217238 2019-04-24T20:55:44Z 2019-04-24T20:55:44Z MEMBER

It might make sense to print a warning if a group was not explicitly selected, the root group is empty and there is another non-empty group. Though I'm a little reluctant to do this since empty groups are perfectly valid, and it's a little annoying to get warnings for things that may not be programmer errors.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736
486276970 https://github.com/pydata/xarray/issues/2916#issuecomment-486276970 https://api.github.com/repos/pydata/xarray/issues/2916 MDEyOklzc3VlQ29tbWVudDQ4NjI3Njk3MA== dcherian 2448579 2019-04-24T14:55:10Z 2019-04-24T14:55:10Z MEMBER

I'm in favour of printing out a nice warning message when the netcdf file has groups. Listing them would be even better.

Also it looks like the docs need to be updated to mention netCDF groups: https://xarray.pydata.org/en/stable/io.html#netcdf

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.open_dataset no groups info 436669736

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);