issue_comments

Table actions

7 rows where issue = 434599855 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Partial fix for #2841 to improve formatting. · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
484955366 https://github.com/pydata/xarray/pull/2906#issuecomment-484955366 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDk1NTM2Ng== max-sixty 5635139 2019-04-19T16:53:44Z 2019-04-19T16:53:44Z MEMBER

OK, thanks @dnowacki-usgs !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484951848 https://github.com/pydata/xarray/pull/2906#issuecomment-484951848 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDk1MTg0OA== dnowacki-usgs 13837821 2019-04-19T16:38:48Z 2019-04-19T16:38:48Z CONTRIBUTOR

Good to go as far as I'm concerned. I'm not even sure how I'd phrase these changes in whats-new, so let's go with it as-is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484645088 https://github.com/pydata/xarray/pull/2906#issuecomment-484645088 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDY0NTA4OA== shoyer 1217238 2019-04-18T19:05:02Z 2019-04-18T19:05:02Z MEMBER

Looks great! You can ignore the failing doc build in the tests, that is unrelated.

If you like, feel free to give yourself a credit in whats-new.rst for fixing this. Otherwise I'll merge this in a day or two.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484605054 https://github.com/pydata/xarray/pull/2906#issuecomment-484605054 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDYwNTA1NA== dnowacki-usgs 13837821 2019-04-18T17:34:24Z 2019-04-18T17:34:24Z CONTRIBUTOR

Thanks @shoyer. I think numeric indexes are clearer, though maybe not cleaner. Removed them and fixed the dask CI test I didn't catch the first time through. Hopefully everything passes now. 🤞 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484364344 https://github.com/pydata/xarray/pull/2906#issuecomment-484364344 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDM2NDM0NA== pep8speaks 24736507 2019-04-18T05:45:59Z 2019-04-18T17:20:14Z NONE

Hello @dnowacki-usgs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-18 17:20:14 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484524659 https://github.com/pydata/xarray/pull/2906#issuecomment-484524659 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDUyNDY1OQ== max-sixty 5635139 2019-04-18T14:06:07Z 2019-04-18T14:06:07Z MEMBER

Also come Py3.6, f strings 🙏 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855
484378485 https://github.com/pydata/xarray/pull/2906#issuecomment-484378485 https://api.github.com/repos/pydata/xarray/issues/2906 MDEyOklzc3VlQ29tbWVudDQ4NDM3ODQ4NQ== shoyer 1217238 2019-04-18T06:51:30Z 2019-04-18T06:51:30Z MEMBER

Thanks @dnowacki-usgs !

One minor note -- it's valid (since Python 2.7) to write string formatting with explicit positional indexes, e.g., you could just write '{} {}'.format('one', 'two') rather than '{0} {1}'.format('one', 'two').

I think it's usually a little cleaner to omit the numeric indices, unless you're reusing arguments multiple times or printing the names out of order. (But even in these cases it's usually nicer to use keyword names.)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Partial fix for #2841 to improve formatting. 434599855

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);