issue_comments

Table actions

10 rows where issue = 433490801 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Handle the character array dim name · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
485031958 https://github.com/pydata/xarray/pull/2896#issuecomment-485031958 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NTAzMTk1OA== castelao 1903589 2019-04-19T22:48:54Z 2019-04-19T22:48:54Z NONE

Perfect timing, I just needed that! Thanks @jmccreight et al

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484970400 https://github.com/pydata/xarray/pull/2896#issuecomment-484970400 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDk3MDQwMA== dcherian 2448579 2019-04-19T17:53:01Z 2019-04-19T17:53:01Z MEMBER

Thanks @jmccreight 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484966484 https://github.com/pydata/xarray/pull/2896#issuecomment-484966484 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDk2NjQ4NA== jmccreight 12465248 2019-04-19T17:36:22Z 2019-04-19T17:40:27Z CONTRIBUTOR

🤦‍♂️ with that formatting in the whats-new.rst. (a reminder to squash) I think this is complete. thanks for the mini tour of xarray internals, I learned some useful things! 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484267839 https://github.com/pydata/xarray/pull/2896#issuecomment-484267839 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDI2NzgzOQ== pep8speaks 24736507 2019-04-17T21:26:41Z 2019-04-19T15:13:29Z NONE

Hello @jmccreight! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-19 15:13:29 UTC
 
{
    "total_count": 2,
    "+1": 0,
    "-1": 1,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484766627 https://github.com/pydata/xarray/pull/2896#issuecomment-484766627 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDc2NjYyNw== shoyer 1217238 2019-04-19T04:49:07Z 2019-04-19T04:49:07Z MEMBER

Could you please add a brief note to whats-new.rst? Otherwise this looks good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484689541 https://github.com/pydata/xarray/pull/2896#issuecomment-484689541 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDY4OTU0MQ== jmccreight 12465248 2019-04-18T21:05:33Z 2019-04-18T21:05:33Z CONTRIBUTOR

🎊 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484678210 https://github.com/pydata/xarray/pull/2896#issuecomment-484678210 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDY3ODIxMA== dcherian 2448579 2019-04-18T20:27:46Z 2019-04-18T20:27:46Z MEMBER

One is a lint failure: https://github.com/pydata/xarray/pull/2896#issuecomment-484267839

The docs failure looks like a cartopy install problem

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484676251 https://github.com/pydata/xarray/pull/2896#issuecomment-484676251 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDY3NjI1MQ== jmccreight 12465248 2019-04-18T20:22:55Z 2019-04-18T20:22:55Z CONTRIBUTOR

I'm uncertain why travis is failing. Two of them look http-related and the other maybe be docs-related (but dont trust me). Running pytest locallin in the xarray/tests/ dir ============== 7007 passed, 1170 skipped, 25 xfailed, 1 xpassed, 30 warnings in 62.12 seconds ==============

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
484272294 https://github.com/pydata/xarray/pull/2896#issuecomment-484272294 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4NDI3MjI5NA== jmccreight 12465248 2019-04-17T21:42:08Z 2019-04-17T21:42:08Z CONTRIBUTOR

@shoyer Added test and documentation. I did not build documentation, wasnt sure if that was necessary. The history should be squashed when the time comes...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801
483700694 https://github.com/pydata/xarray/pull/2896#issuecomment-483700694 https://api.github.com/repos/pydata/xarray/issues/2896 MDEyOklzc3VlQ29tbWVudDQ4MzcwMDY5NA== jmccreight 12465248 2019-04-16T15:04:46Z 2019-04-16T15:04:46Z CONTRIBUTOR

thanks, @shoyer. I will add the documentation and tests now that the first hurdle is cleared and update the PR. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle the character array dim name  433490801

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);