issue_comments

Table actions

7 rows where issue = 433410125 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Added docs example for `xarray.Dataset.get()` · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
483643417 https://github.com/pydata/xarray/pull/2894#issuecomment-483643417 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzY0MzQxNw== dcherian 2448579 2019-04-16T12:43:58Z 2019-04-16T12:43:58Z MEMBER

I missed that x is a coordinate.

Thanks @jbusecke

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483460066 https://github.com/pydata/xarray/pull/2894#issuecomment-483460066 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ2MDA2Ng== jbusecke 14314623 2019-04-15T23:53:32Z 2019-04-15T23:53:32Z CONTRIBUTOR

How about this one?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483459088 https://github.com/pydata/xarray/pull/2894#issuecomment-483459088 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ1OTA4OA== shoyer 1217238 2019-04-15T23:48:02Z 2019-04-15T23:48:02Z MEMBER

Yes, I think it would make more sense to add an example with another variable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483458809 https://github.com/pydata/xarray/pull/2894#issuecomment-483458809 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ1ODgwOQ== jbusecke 14314623 2019-04-15T23:46:23Z 2019-04-15T23:46:49Z CONTRIBUTOR

I am still a bit puzzled over the ds[['x', 'temperature']] suggestion. Maybe I am not getting something, but x is a dimension and the output of ds[['x', 'temperature']] is the same as ds[['temperature']]. I think it would be clearer to add a third variable (maybe in the code block above) and then select two out of three data variables?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483457747 https://github.com/pydata/xarray/pull/2894#issuecomment-483457747 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ1Nzc0Nw== shoyer 1217238 2019-04-15T23:40:44Z 2019-04-15T23:40:44Z MEMBER

So should I just add an example with multiple variables using ds[['var1', 'var2']]?

I think this is probably a better idea.

To be honest, I don't know if .get() if useful for anyone with a list -- it's implementation here was really an accident (based on how Mapping.get works) rather than an intentional choice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483457364 https://github.com/pydata/xarray/pull/2894#issuecomment-483457364 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ1NzM2NA== jbusecke 14314623 2019-04-15T23:38:41Z 2019-04-15T23:38:41Z CONTRIBUTOR

Oh I see. It returns None if any of the keys is not found. That might indeed lead to confusion. So should I just add an example with multiple variables using ds[['var1', 'var2']]?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125
483455690 https://github.com/pydata/xarray/pull/2894#issuecomment-483455690 https://api.github.com/repos/pydata/xarray/issues/2894 MDEyOklzc3VlQ29tbWVudDQ4MzQ1NTY5MA== shoyer 1217238 2019-04-15T23:29:48Z 2019-04-15T23:29:48Z MEMBER

For context: we didn't explicitly implement a .get() method on Dataset, we get it implemented for free because xarray.Dataset inherits from collections.abc.Mapping. So the only practical difference between .get() and [] on Dataset is the same as the difference for a general Python mapping: .get() returns a default value (which defaults to None) instead of raising KeyError.

I'm not sure it's particularly useful to show examples using .get() here, unless we want to show this difference in behavior if a key is not found.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added docs example for `xarray.Dataset.get()` 433410125

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);