issue_comments

Table actions

7 rows where issue = 431970156 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Expose use_cftime option in open_zarr · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
594736618 https://github.com/pydata/xarray/issues/2886#issuecomment-594736618 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDU5NDczNjYxOA== max-sixty 5635139 2020-03-04T18:36:18Z 2020-03-04T18:36:18Z MEMBER

@spencerkclark @dcherian for transparency I unpinned this to make room for the broken docs -> github link. Feel free to unpin the build warnings if this is still top-of-mind

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
525864934 https://github.com/pydata/xarray/issues/2886#issuecomment-525864934 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUyNTg2NDkzNA== rabernat 1197350 2019-08-28T18:23:13Z 2019-08-28T18:23:13Z MEMBER

Adding tests to #3229 should be pretty straightforward. Great project for someone looking to learn a bit more about xarray internals.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
525831230 https://github.com/pydata/xarray/issues/2886#issuecomment-525831230 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUyNTgzMTIzMA== Geektrovert 13296694 2019-08-28T16:55:06Z 2019-08-28T16:55:06Z CONTRIBUTOR

@naomi-henderson, I was working on this. But lately, I have been quite busy so I haven't implemented the tests yet. You can fix it if you wish to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
525418536 https://github.com/pydata/xarray/issues/2886#issuecomment-525418536 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUyNTQxODUzNg== naomi-henderson 31460695 2019-08-27T18:08:07Z 2019-08-27T18:08:07Z NONE

@Geektrovert and @spencerkclark - any progress on this? It would be great to have it working in time for the CMIP6 hackathon in order to suppress all of the warning messages when opening zarr stores. For example, a zarr store using cftime.DatetimeGregorian (e.g., cftime.DatetimeGregorian(2349, 12, 16, 12, 0, 0, 0, 4, 350)) will always generate the warning: /usr/local/python/anaconda3/envs/pangeoJun2019/lib/python3.6/site-packages/xarray/coding/times.py:465: SerializationWarning: Unable to decode time axis into full numpy.datetime64 objects, continuing using cftime.datetime objects instead, reason: dates out of range dtype = _decode_cf_datetime_dtype(data, units, calendar, self.use_cftime) /usr/local/python/anaconda3/envs/pangeoJun2019/lib/python3.6/site-packages/xarray/coding/times.py:465: SerializationWarning: Unable to decode time axis into full numpy.datetime64 objects, continuing using cftime.datetime objects instead, reason: dates out of range dtype = _decode_cf_datetime_dtype(data, units, calendar, self.use_cftime) /usr/local/python/anaconda3/envs/pangeoJun2019/lib/python3.6/site-packages/numpy/core/numeric.py:538: SerializationWarning: Unable to decode time axis into full numpy.datetime64 objects, continuing using cftime.datetime objects instead, reason: dates out of range return array(a, dtype, copy=False, order=order) For the CMIP6 collection, I always use use_cftime=True in open_mfdataset, but then when I make the zarr store and read it back in, it generates these warnings - always a distraction for anyone not used to dealing with this data

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
522575713 https://github.com/pydata/xarray/issues/2886#issuecomment-522575713 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUyMjU3NTcxMw== Geektrovert 13296694 2019-08-19T13:29:29Z 2019-08-19T13:29:29Z CONTRIBUTOR

Couldn't figure out how to implement the tests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
517487516 https://github.com/pydata/xarray/issues/2886#issuecomment-517487516 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUxNzQ4NzUxNg== spencerkclark 6628425 2019-08-01T23:00:51Z 2019-08-01T23:00:51Z MEMBER

Absolutely - I think this should be as simple as adding a use_cftime argument to open_zarr, threading its value through as an argument to the call to conventions.decode_cf here: https://github.com/pydata/xarray/blob/7b76f163394a35c9cd8013e835e9d0b2050fd9a6/xarray/backends/zarr.py#L542-L545

and adding a test to make sure it works.

For more general tips on contributing to xarray, see the contributing guide here.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156
517273076 https://github.com/pydata/xarray/issues/2886#issuecomment-517273076 https://api.github.com/repos/pydata/xarray/issues/2886 MDEyOklzc3VlQ29tbWVudDUxNzI3MzA3Ng== Geektrovert 13296694 2019-08-01T12:49:59Z 2019-08-01T12:49:59Z CONTRIBUTOR

Hey, can I work on this issue? I'm still new to this so a little heads up would be very nice!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose use_cftime option in open_zarr 431970156

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);