issue_comments

Table actions

5 rows where issue = 429685866 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • xarray.concat docstring confuses PyCharm type detection · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
481881326 https://github.com/pydata/xarray/issues/2869#issuecomment-481881326 https://api.github.com/repos/pydata/xarray/issues/2869 MDEyOklzc3VlQ29tbWVudDQ4MTg4MTMyNg== crusaderky 6213168 2019-04-10T21:53:45Z 2019-04-10T21:53:45Z MEMBER

2877 doesn't fix it... More pulls will be needed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat docstring confuses PyCharm type detection 429685866
480579674 https://github.com/pydata/xarray/issues/2869#issuecomment-480579674 https://api.github.com/repos/pydata/xarray/issues/2869 MDEyOklzc3VlQ29tbWVudDQ4MDU3OTY3NA== crusaderky 6213168 2019-04-07T10:56:58Z 2019-04-07T10:56:58Z MEMBER

@shoyer indeed. I'll start working on type annotations straight away.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat docstring confuses PyCharm type detection 429685866
480376444 https://github.com/pydata/xarray/issues/2869#issuecomment-480376444 https://api.github.com/repos/pydata/xarray/issues/2869 MDEyOklzc3VlQ29tbWVudDQ4MDM3NjQ0NA== shoyer 1217238 2019-04-05T18:24:55Z 2019-04-05T18:24:55Z MEMBER

Interesting, we could definitely fix this.

Actually, I suspect the ideal situation would be to use type annotations -- then PyCharm should not need to inspect the docstrings at all.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat docstring confuses PyCharm type detection 429685866
480303272 https://github.com/pydata/xarray/issues/2869#issuecomment-480303272 https://api.github.com/repos/pydata/xarray/issues/2869 MDEyOklzc3VlQ29tbWVudDQ4MDMwMzI3Mg== gimperiale 47244312 2019-04-05T14:47:29Z 2019-04-05T14:47:29Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat docstring confuses PyCharm type detection 429685866
480260204 https://github.com/pydata/xarray/issues/2869#issuecomment-480260204 https://api.github.com/repos/pydata/xarray/issues/2869 MDEyOklzc3VlQ29tbWVudDQ4MDI2MDIwNA== max-sixty 5635139 2019-04-05T12:38:29Z 2019-04-05T12:38:29Z MEMBER

Do we know why it thinks it's type?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat docstring confuses PyCharm type detection 429685866

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);