issue_comments

Table actions

4 rows where issue = 427410885 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 4 ✖

issue 1

  • Quadratic slowdown when saving multiple datasets to the same h5 file (h5netcdf) · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1010716076 https://github.com/pydata/xarray/issues/2857#issuecomment-1010716076 https://api.github.com/repos/pydata/xarray/issues/2857 IC_kwDOAMm_X848Pk2s shoyer 1217238 2022-01-12T07:18:57Z 2022-01-12T07:18:57Z MEMBER

Well done, Kai!

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quadratic slowdown when saving multiple datasets to the same h5 file (h5netcdf) 427410885
807472405 https://github.com/pydata/xarray/issues/2857#issuecomment-807472405 https://api.github.com/repos/pydata/xarray/issues/2857 MDEyOklzc3VlQ29tbWVudDgwNzQ3MjQwNQ== shoyer 1217238 2021-03-25T20:56:36Z 2021-03-25T20:56:36Z MEMBER

It appears that issues can only be moved within a GitHub organization. So I guess we'll need to start a new one.

On Thu, Mar 25, 2021 at 12:35 PM Kai Mühlbauer @.***> wrote:

@shoyer https://github.com/shoyer Could we move the entire issue? Or just open another one over at 'h5netcdf' and reference this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2857#issuecomment-807344131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVRZOCDSW7GMLVHBYPDTFOF7DANCNFSM4HCRQYLA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quadratic slowdown when saving multiple datasets to the same h5 file (h5netcdf) 427410885
807319582 https://github.com/pydata/xarray/issues/2857#issuecomment-807319582 https://api.github.com/repos/pydata/xarray/issues/2857 MDEyOklzc3VlQ29tbWVudDgwNzMxOTU4Mg== shoyer 1217238 2021-03-25T19:19:08Z 2021-03-25T19:19:08Z MEMBER

I suspect this could be solved by adding an optimization into h5netcdf to only call _attach_dim_scales() (and maybe some other methods) on variables/groups that have been modified (as opposed to the entire file).

It's probably worth moving the discussion over into the h5netcdf tracker, anyways :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quadratic slowdown when saving multiple datasets to the same h5 file (h5netcdf) 427410885
478359263 https://github.com/pydata/xarray/issues/2857#issuecomment-478359263 https://api.github.com/repos/pydata/xarray/issues/2857 MDEyOklzc3VlQ29tbWVudDQ3ODM1OTI2Mw== shoyer 1217238 2019-03-31T17:03:21Z 2019-03-31T17:03:21Z MEMBER

I don't think this is expected. Can you try profiling to_netcdf() (e.g., %prun in IPython) to see what the source of slow down is?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quadratic slowdown when saving multiple datasets to the same h5 file (h5netcdf) 427410885

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);