issue_comments

Table actions

8 rows where issue = 424916834 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • More informative error when writing attrs to netCDF · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
479556697 https://github.com/pydata/xarray/pull/2850#issuecomment-479556697 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTU1NjY5Nw== shoyer 1217238 2019-04-03T16:11:41Z 2019-04-03T16:11:41Z MEMBER

Yes, you can put these in a netCDF3 file (even with the latest netCDF-C library).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479547573 https://github.com/pydata/xarray/pull/2850#issuecomment-479547573 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTU0NzU3Mw== fmaussion 10050469 2019-04-03T15:48:22Z 2019-04-03T15:48:22Z MEMBER

Thanks! @shoyer ! I guess the file I was working with must have been created with nectdf3 then, because otherwise I don't know how they managed to write this out...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479539924 https://github.com/pydata/xarray/pull/2850#issuecomment-479539924 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTUzOTkyNA== shoyer 1217238 2019-04-03T15:30:05Z 2019-04-03T15:30:05Z MEMBER

I think this is actually due to something in the netCDF C library: CLASS is a special attribute name used by HDF5 dimension scales. Note that it works fine to save an attribute with the name class (the Python keyword).

Here's the list of prohibited attributes from the netCDF spec: https://www.unidata.ucar.edu/software/netcdf/docs/file_format_specifications.html#atts_spec

h5netcdf uses this list to issue more informative error messages: https://github.com/shoyer/h5netcdf/blob/3ae35cd58297281a1dc69c46fb0b315a0007ac2b/h5netcdf/attrs.py#L22-L24

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479528667 https://github.com/pydata/xarray/pull/2850#issuecomment-479528667 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTUyODY2Nw== fmaussion 10050469 2019-04-03T15:03:19Z 2019-04-03T15:03:19Z MEMBER

It's very python related

I'm saying this because this happened with a real file I was working with. The file had a CLASS attribute on a variable, it can be read by xarray but not written out... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479527736 https://github.com/pydata/xarray/pull/2850#issuecomment-479527736 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTUyNzczNg== fmaussion 10050469 2019-04-03T15:01:12Z 2019-04-03T15:01:12Z MEMBER

One more request: can you link to a list of disallowed names in the docs somewhere?

I don't know if such a list exists. Do you know? It's very python related, because of setattr. It's confusing that it's only making a problem on variable objects, not on datasets.

So altogether I wouldn't worry much here, this is really an edge case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479522682 https://github.com/pydata/xarray/pull/2850#issuecomment-479522682 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTUyMjY4Mg== dcherian 2448579 2019-04-03T14:49:17Z 2019-04-03T14:49:17Z MEMBER

One more request: can you link to a list of disallowed names in the docs somewhere?

I also wonder if the error message should suggest that the user look up this list.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
479382381 https://github.com/pydata/xarray/pull/2850#issuecomment-479382381 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3OTM4MjM4MQ== fmaussion 10050469 2019-04-03T08:00:40Z 2019-04-03T08:00:40Z MEMBER

Done! Didn't edit "what's new" because this is a tiny change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834
476209105 https://github.com/pydata/xarray/pull/2850#issuecomment-476209105 https://api.github.com/repos/pydata/xarray/issues/2850 MDEyOklzc3VlQ29tbWVudDQ3NjIwOTEwNQ== pep8speaks 24736507 2019-03-25T13:58:39Z 2019-04-01T09:01:17Z NONE

Hello @fmaussion! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-01 09:01:17 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More informative error when writing attrs to netCDF 424916834

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);