issue_comments

Table actions

4 rows where issue = 424348180 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix formatting of engine parameter in docstrings · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
476033832 https://github.com/pydata/xarray/pull/2846#issuecomment-476033832 https://api.github.com/repos/pydata/xarray/issues/2846 MDEyOklzc3VlQ29tbWVudDQ3NjAzMzgzMg== shoyer 1217238 2019-03-25T02:30:09Z 2019-03-25T02:30:09Z MEMBER

thanks for looking into this @spencermathews !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix formatting of engine parameter in docstrings 424348180
475797172 https://github.com/pydata/xarray/pull/2846#issuecomment-475797172 https://api.github.com/repos/pydata/xarray/issues/2846 MDEyOklzc3VlQ29tbWVudDQ3NTc5NzE3Mg== spencermathews 1855348 2019-03-22T21:58:40Z 2019-03-22T22:03:06Z CONTRIBUTOR

Yes, it seemed like such a simple fix, until the PEP 8 bit. I came across numpy/numpydoc#87, which seems apropos. I pushed an update that should fix the linter error. If sphinx isn't happy it's not complaining.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix formatting of engine parameter in docstrings 424348180
475734752 https://github.com/pydata/xarray/pull/2846#issuecomment-475734752 https://api.github.com/repos/pydata/xarray/issues/2846 MDEyOklzc3VlQ29tbWVudDQ3NTczNDc1Mg== pep8speaks 24736507 2019-03-22T18:37:28Z 2019-03-22T21:31:25Z NONE

Hello @spencermathews! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-03-22 21:31:25 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix formatting of engine parameter in docstrings 424348180
475762454 https://github.com/pydata/xarray/pull/2846#issuecomment-475762454 https://api.github.com/repos/pydata/xarray/issues/2846 MDEyOklzc3VlQ29tbWVudDQ3NTc2MjQ1NA== shoyer 1217238 2019-03-22T20:05:17Z 2019-03-22T20:05:17Z MEMBER

Hmm. I wish there was a way to do this so both sphinx and lint checkers were happy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix formatting of engine parameter in docstrings 424348180

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);