issue_comments

Table actions

9 rows where issue = 423749397 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • xarray.concat() with compat='identical' fails for DataArray attrs · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
475659970 https://github.com/pydata/xarray/issues/2836#issuecomment-475659970 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTY1OTk3MA== dcherian 2448579 2019-03-22T15:15:14Z 2019-03-22T15:15:14Z MEMBER

No I mean having datarrays as attrs. Your use case is likely satisfied by seeing non-dimension coordinates. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475657814 https://github.com/pydata/xarray/issues/2836#issuecomment-475657814 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTY1NzgxNA== shoyer 1217238 2019-03-22T15:09:38Z 2019-03-22T15:09:38Z MEMBER

It's true that you won't be able to serialize nested xarray objects to netCDF, but for the most part we try to avoid putting restrictions on what you can put inside xarray objects in memory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475605323 https://github.com/pydata/xarray/issues/2836#issuecomment-475605323 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTYwNTMyMw== aldanor 2418513 2019-03-22T12:36:48Z 2019-03-22T12:36:48Z NONE

Ooh I missed that too! This probably wont serialize well to netcdf, would it?

Prob not, with n-d attrs? It would serialize just fine to plain HDF5 though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475604480 https://github.com/pydata/xarray/issues/2836#issuecomment-475604480 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTYwNDQ4MA== dcherian 2448579 2019-03-22T12:34:18Z 2019-03-22T12:34:18Z MEMBER

Ooh I missed that too! This probably wont serialize well to netcdf, would it? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475488251 https://github.com/pydata/xarray/issues/2836#issuecomment-475488251 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTQ4ODI1MQ== shoyer 1217238 2019-03-22T04:14:23Z 2019-03-22T04:14:23Z MEMBER

This was intended to work with numpy arrays -- you'll notice that xarray.core.utils.equivalent() includes specific logic for numpy arrays.

We could probably adjust this to handle xarray objects, though this is a somewhat unusual use case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475285050 https://github.com/pydata/xarray/issues/2836#issuecomment-475285050 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTI4NTA1MA== aldanor 2418513 2019-03-21T15:46:13Z 2019-03-21T15:46:13Z NONE

I could try; what's the most stable way to check equality? Do we want to enforce that types are the same, shame/ndim are the same (dtypes?), plus element-wise comparison? What if one is DA array, one is np array?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475275097 https://github.com/pydata/xarray/issues/2836#issuecomment-475275097 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTI3NTA5Nw== dcherian 2448579 2019-03-21T15:24:45Z 2019-03-21T15:24:45Z MEMBER

Ah right. Sorry, I missed that. Can you open a PR to fix it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475264613 https://github.com/pydata/xarray/issues/2836#issuecomment-475264613 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTI2NDYxMw== aldanor 2418513 2019-03-21T14:59:28Z 2019-03-21T14:59:28Z NONE

@dcherian In the second example that fails, the attr in question is 1-D, one-dimensional attributes are fine?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397
475262968 https://github.com/pydata/xarray/issues/2836#issuecomment-475262968 https://api.github.com/repos/pydata/xarray/issues/2836 MDEyOklzc3VlQ29tbWVudDQ3NTI2Mjk2OA== dcherian 2448579 2019-03-21T14:55:31Z 2019-03-21T14:55:31Z MEMBER

I think multidimensional attributes are not allowed in netCDF: https://github.com/pydata/xarray/issues/2803 though we don't raise an error yet. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.concat() with compat='identical' fails for DataArray attrs 423749397

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);