issue_comments

Table actions

6 rows where issue = 423405197 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 3

issue 1

  • Add quantile method to GroupBy · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505057636 https://github.com/pydata/xarray/pull/2828#issuecomment-505057636 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDUwNTA1NzYzNg== shoyer 1217238 2019-06-24T15:21:36Z 2019-06-24T15:21:36Z MEMBER

Thanks @huard !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197
501350450 https://github.com/pydata/xarray/pull/2828#issuecomment-501350450 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDUwMTM1MDQ1MA== pep8speaks 24736507 2019-06-12T16:25:08Z 2019-06-24T15:19:41Z NONE

Hello @huard! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-06-24 15:19:40 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197
504677311 https://github.com/pydata/xarray/pull/2828#issuecomment-504677311 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDUwNDY3NzMxMQ== dcherian 2448579 2019-06-22T15:58:42Z 2019-06-22T15:58:42Z MEMBER

LGTM.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197
475198404 https://github.com/pydata/xarray/pull/2828#issuecomment-475198404 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDQ3NTE5ODQwNA== huard 81219 2019-03-21T11:44:32Z 2019-03-21T11:44:32Z CONTRIBUTOR

Made the change. I had to drop the quantile dimension for scalar q after the apply to maintain the same behavior as DataArray.quantile, but it got me wondering if keeping the quantile dimension even for scalar q should not be the default. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197
475030136 https://github.com/pydata/xarray/pull/2828#issuecomment-475030136 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDQ3NTAzMDEzNg== shoyer 1217238 2019-03-20T21:11:44Z 2019-03-20T21:11:44Z MEMBER

I just realized that I could do da.groupby('time.month').apply(xr.DataArray.quantile, q=.5, dim='time') which seems to yield the same results.

Yes, I think this would be the preferred way to implement this :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197
474998958 https://github.com/pydata/xarray/pull/2828#issuecomment-474998958 https://api.github.com/repos/pydata/xarray/issues/2828 MDEyOklzc3VlQ29tbWVudDQ3NDk5ODk1OA== huard 81219 2019-03-20T19:42:45Z 2019-03-20T19:42:45Z CONTRIBUTOR

I just realized that I could do da.groupby('time.month').apply(xr.DataArray.quantile, q=.5, dim='time') which seems to yield the same results. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add quantile method to GroupBy 423405197

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);