issue_comments

Table actions

6 rows where issue = 417542619 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Test failure with TestValidateAttrs.test_validating_attrs · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
680060278 https://github.com/pydata/xarray/issues/2803#issuecomment-680060278 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDY4MDA2MDI3OA== hmaarrfk 90008 2020-08-25T14:29:18Z 2020-08-25T14:29:18Z CONTRIBUTOR

Sorry for noise. It seems that 1D arrays are still supported.

I still had a 2D array lingering in my codebase.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619
679399158 https://github.com/pydata/xarray/issues/2803#issuecomment-679399158 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDY3OTM5OTE1OA== hmaarrfk 90008 2020-08-24T22:31:09Z 2020-08-24T22:31:09Z CONTRIBUTOR

With the netcdf4 back end, I'm not able to save a 1D attr dataset.

I can save my dataset with the h5netcdf backend

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619
679352344 https://github.com/pydata/xarray/issues/2803#issuecomment-679352344 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDY3OTM1MjM0NA== dcherian 2448579 2020-08-24T20:36:18Z 2020-08-24T20:36:18Z MEMBER

I remember being surprised by this: xr.tutorial.load_dataset("air_temperature").air.attrs["actual_range"] gives array([185.16, 322.1 ], dtype=float32)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619
679348131 https://github.com/pydata/xarray/issues/2803#issuecomment-679348131 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDY3OTM0ODEzMQ== hmaarrfk 90008 2020-08-24T20:26:49Z 2020-08-24T20:26:49Z CONTRIBUTOR

Sorry for posting on such an old thread.

Are attrs supposed to support 1D arrays?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619
472067849 https://github.com/pydata/xarray/issues/2803#issuecomment-472067849 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDQ3MjA2Nzg0OQ== shoyer 1217238 2019-03-12T16:12:00Z 2019-03-12T16:12:00Z MEMBER

Yes, those both sound like good options to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619
472034107 https://github.com/pydata/xarray/issues/2803#issuecomment-472034107 https://api.github.com/repos/pydata/xarray/issues/2803 MDEyOklzc3VlQ29tbWVudDQ3MjAzNDEwNw== jhamman 2443309 2019-03-12T14:53:11Z 2019-03-12T14:53:11Z MEMBER

@shoyer - I'm surprised we had a test for this behavior. Based on https://github.com/Unidata/netcdf4-python/issues/841, it seems we don't want this behavior to work. Can we just remove this test (or better yet, insure the ValueError is raised)? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure with TestValidateAttrs.test_validating_attrs 417542619

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);