issue_comments

Table actions

3 rows where issue = 406971782 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • 1000x performance regression in transpose from disk between libnetcdf 4.6.1 and 4.6.2 · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
678810706 https://github.com/pydata/xarray/issues/2747#issuecomment-678810706 https://api.github.com/repos/pydata/xarray/issues/2747 MDEyOklzc3VlQ29tbWVudDY3ODgxMDcwNg== shoyer 1217238 2020-08-23T18:53:41Z 2020-08-23T18:53:41Z MEMBER

Yes, it looks like this was fixed in https://github.com/Unidata/netcdf4-python/pull/872.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1000x performance regression in transpose from disk between libnetcdf 4.6.1 and 4.6.2 406971782
678810174 https://github.com/pydata/xarray/issues/2747#issuecomment-678810174 https://api.github.com/repos/pydata/xarray/issues/2747 MDEyOklzc3VlQ29tbWVudDY3ODgxMDE3NA== mathause 10194086 2020-08-23T18:47:40Z 2020-08-23T18:47:40Z MEMBER

Is this fixed upstream? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1000x performance regression in transpose from disk between libnetcdf 4.6.1 and 4.6.2 406971782
460880404 https://github.com/pydata/xarray/issues/2747#issuecomment-460880404 https://api.github.com/repos/pydata/xarray/issues/2747 MDEyOklzc3VlQ29tbWVudDQ2MDg4MDQwNA== shoyer 1217238 2019-02-06T02:28:55Z 2019-02-06T02:28:55Z MEMBER

Thanks for the clear report! I was able to reproduce this and have reported the issue upstream: https://github.com/Unidata/netcdf4-python/issues/870

In the meantime, we could probably optimize this path in xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1000x performance regression in transpose from disk between libnetcdf 4.6.1 and 4.6.2 406971782

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);