issue_comments

Table actions

7 rows where issue = 406035264 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • add h5netcdf+dask tests · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
462623627 https://github.com/pydata/xarray/pull/2737#issuecomment-462623627 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MjYyMzYyNw== shoyer 1217238 2019-02-12T05:39:14Z 2019-02-12T05:39:14Z MEMBER

that is a little disconcerting, but yes let's merge this

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
462091115 https://github.com/pydata/xarray/pull/2737#issuecomment-462091115 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MjA5MTExNQ== jhamman 2443309 2019-02-10T00:03:33Z 2019-02-10T00:03:33Z MEMBER

@shoyer - good to merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
461280392 https://github.com/pydata/xarray/pull/2737#issuecomment-461280392 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MTI4MDM5Mg== jhamman 2443309 2019-02-07T03:58:08Z 2019-02-07T03:58:08Z MEMBER

@shoyer - yes, you fixed the existing bug in #2696 😄 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
461271393 https://github.com/pydata/xarray/pull/2737#issuecomment-461271393 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MTI3MTM5Mw== shoyer 1217238 2019-02-07T02:57:18Z 2019-02-07T02:57:18Z MEMBER

Did the changes to dataset.py really become entirely irrelevant with merging master?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
461262818 https://github.com/pydata/xarray/pull/2737#issuecomment-461262818 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MTI2MjgxOA== jhamman 2443309 2019-02-07T02:05:47Z 2019-02-07T02:05:47Z MEMBER

This is ready for a final review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
460009703 https://github.com/pydata/xarray/pull/2737#issuecomment-460009703 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MDAwOTcwMw== pep8speaks 24736507 2019-02-02T23:50:23Z 2019-02-07T01:18:56Z NONE

Hello @jhamman! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 07, 2019 at 01:18 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264
460135549 https://github.com/pydata/xarray/pull/2737#issuecomment-460135549 https://api.github.com/repos/pydata/xarray/issues/2737 MDEyOklzc3VlQ29tbWVudDQ2MDEzNTU0OQ== jhamman 2443309 2019-02-04T05:31:20Z 2019-02-04T05:31:20Z MEMBER

Should be good to go here once the tests finish. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add h5netcdf+dask tests 406035264

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);