issue_comments

Table actions

4 rows where issue = 405478969 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • BUG: Pass kwargs to the FileManager for pynio engine (#2380) · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
461271264 https://github.com/pydata/xarray/pull/2732#issuecomment-461271264 https://api.github.com/repos/pydata/xarray/issues/2732 MDEyOklzc3VlQ29tbWVudDQ2MTI3MTI2NA== shoyer 1217238 2019-02-07T02:56:32Z 2019-02-07T02:56:32Z MEMBER

thanks @jonmjoyce !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Pass kwargs to the FileManager for pynio engine (#2380) 405478969
460469157 https://github.com/pydata/xarray/pull/2732#issuecomment-460469157 https://api.github.com/repos/pydata/xarray/issues/2732 MDEyOklzc3VlQ29tbWVudDQ2MDQ2OTE1Nw== pep8speaks 24736507 2019-02-05T00:34:55Z 2019-02-07T02:56:18Z NONE

Hello @jonmjoyce! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 07, 2019 at 02:56 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Pass kwargs to the FileManager for pynio engine (#2380) 405478969
459806530 https://github.com/pydata/xarray/pull/2732#issuecomment-459806530 https://api.github.com/repos/pydata/xarray/issues/2732 MDEyOklzc3VlQ29tbWVudDQ1OTgwNjUzMA== jonmjoyce 45802786 2019-02-01T17:46:21Z 2019-02-01T17:46:21Z CONTRIBUTOR

I would like to, but honestly I'm pretty new to Python and didn't understand how the tests worked. I found the TestPyNio class and assume I would add something there but I currently have no idea how to test in Python. I tested manually with this code: xarray.open_dataset(filename, engine='pynio', backend_kwargs={"format":"grib2"})

I'm sure I can figure it out in time (C# and Java background) but any guidance is appreciated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Pass kwargs to the FileManager for pynio engine (#2380) 405478969
459636273 https://github.com/pydata/xarray/pull/2732#issuecomment-459636273 https://api.github.com/repos/pydata/xarray/issues/2732 MDEyOklzc3VlQ29tbWVudDQ1OTYzNjI3Mw== shoyer 1217238 2019-02-01T07:49:40Z 2019-02-01T07:49:40Z MEMBER

Could we add a simple regression test for this? Just an example test that passing some keyword argument through to pynio.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Pass kwargs to the FileManager for pynio engine (#2380) 405478969

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);