issue_comments

Table actions

3 rows where issue = 404119432 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Support variable length string arrays in xarray/zarr · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508829136 https://github.com/pydata/xarray/issues/2724#issuecomment-508829136 https://api.github.com/repos/pydata/xarray/issues/2724 MDEyOklzc3VlQ29tbWVudDUwODgyOTEzNg== shoyer 1217238 2019-07-05T18:02:36Z 2019-07-05T18:02:36Z MEMBER

Yes, I think this was fixed in #2706

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support variable length string arrays in xarray/zarr 404119432
508677946 https://github.com/pydata/xarray/issues/2724#issuecomment-508677946 https://api.github.com/repos/pydata/xarray/issues/2724 MDEyOklzc3VlQ29tbWVudDUwODY3Nzk0Ng== shikharsg 8643775 2019-07-05T08:29:11Z 2019-07-05T08:29:11Z NONE

can this be closed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support variable length string arrays in xarray/zarr 404119432
458808896 https://github.com/pydata/xarray/issues/2724#issuecomment-458808896 https://api.github.com/repos/pydata/xarray/issues/2724 MDEyOklzc3VlQ29tbWVudDQ1ODgwODg5Ng== shoyer 1217238 2019-01-30T04:36:27Z 2019-01-30T04:36:27Z MEMBER

When we first added zarr support, either it didn't support variable length strings or I didn't know about it! (see https://github.com/zarr-developers/zarr-specs/issues/6). But zarr definitely does support variable length strings now (https://zarr.readthedocs.io/en/stable/tutorial.html#string-arrays), and I think it would be pretty easy to support in xarray, too.

You'd need to set allows_unicode=True here: https://github.com/pydata/xarray/blob/e8bf4bf9a744148f1f6586cabe7f5c5ef6e9bf26/xarray/backends/zarr.py#L211-L216

and then be sure to pass in dtype=str when constructing the zarr array (see _nc4_dtype in the netCDF4 backend for an example of this)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support variable length string arrays in xarray/zarr 404119432

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);