issue_comments

Table actions

8 rows where issue = 403601219 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Quarter offset implemented (base is now latest pydata-master). · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
468868336 https://github.com/pydata/xarray/pull/2721#issuecomment-468868336 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2ODg2ODMzNg== spencerkclark 6628425 2019-03-02T01:41:11Z 2019-03-02T01:41:11Z MEMBER

Going to go ahead and merge this now; thanks @jwenfai!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
467248139 https://github.com/pydata/xarray/pull/2721#issuecomment-467248139 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2NzI0ODEzOQ== jwenfai 8708062 2019-02-26T00:58:25Z 2019-02-26T00:58:25Z CONTRIBUTOR

@spencerkclark Thanks for improving the docstring and cleaning up the extra whitespaces. They look ok to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
467247046 https://github.com/pydata/xarray/pull/2721#issuecomment-467247046 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2NzI0NzA0Ng== spencerkclark 6628425 2019-02-26T00:53:37Z 2019-02-26T00:53:37Z MEMBER

@jwenfai I made a couple minor edits to the docstrings/comments to bring them up to date (let me know if those look ok). If there are no more comments from others in the next few days, I'll go ahead and merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
467245500 https://github.com/pydata/xarray/pull/2721#issuecomment-467245500 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2NzI0NTUwMA== pep8speaks 24736507 2019-02-26T00:47:05Z 2019-02-26T00:48:47Z NONE

Hello @jwenfai! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 26, 2019 at 00:48 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
460078355 https://github.com/pydata/xarray/pull/2721#issuecomment-460078355 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2MDA3ODM1NQ== jwenfai 8708062 2019-02-03T19:01:04Z 2019-02-03T19:01:04Z CONTRIBUTOR

I didn't realize support for normalization was more involved; normalization-related code should all be removed now. Duplicate entry on whats-new.rst is gone as well. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
460009536 https://github.com/pydata/xarray/pull/2721#issuecomment-460009536 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ2MDAwOTUzNg== jwenfai 8708062 2019-02-02T23:46:43Z 2019-02-02T23:46:43Z CONTRIBUTOR

Sure, I'll add resample support back in once #2593 is merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
459999349 https://github.com/pydata/xarray/pull/2721#issuecomment-459999349 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ1OTk5OTM0OQ== jwenfai 8708062 2019-02-02T21:09:25Z 2019-02-02T21:09:25Z CONTRIBUTOR

Fixes implemented and tests are all passing. I had to modify the tests in test_cftime_offsets.py now that _default_month = 3 for QuarterBegin and QuarterEnd. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219
457958968 https://github.com/pydata/xarray/pull/2721#issuecomment-457958968 https://api.github.com/repos/pydata/xarray/issues/2721 MDEyOklzc3VlQ29tbWVudDQ1Nzk1ODk2OA== spencerkclark 6628425 2019-01-27T22:10:06Z 2019-01-27T22:10:06Z MEMBER

Perfect, @jwenfai, thanks -- I have a busy start to this week, but hopefully I'll get some time to review this by next weekend.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset implemented (base is now latest pydata-master). 403601219

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);