issue_comments

Table actions

5 rows where issue = 403462155 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • ENH: resample methods with tolerance · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
459432101 https://github.com/pydata/xarray/pull/2716#issuecomment-459432101 https://api.github.com/repos/pydata/xarray/issues/2716 MDEyOklzc3VlQ29tbWVudDQ1OTQzMjEwMQ== shoyer 1217238 2019-01-31T17:28:16Z 2019-01-31T17:28:16Z MEMBER

Thanks @observingClouds -- really nice PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: resample methods with tolerance 403462155
458013591 https://github.com/pydata/xarray/pull/2716#issuecomment-458013591 https://api.github.com/repos/pydata/xarray/issues/2716 MDEyOklzc3VlQ29tbWVudDQ1ODAxMzU5MQ== pep8speaks 24736507 2019-01-28T06:35:12Z 2019-01-30T22:33:52Z NONE

Hello @observingClouds! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on January 30, 2019 at 22:33 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: resample methods with tolerance 403462155
457968698 https://github.com/pydata/xarray/pull/2716#issuecomment-457968698 https://api.github.com/repos/pydata/xarray/issues/2716 MDEyOklzc3VlQ29tbWVudDQ1Nzk2ODY5OA== jhamman 2443309 2019-01-28T00:31:55Z 2019-01-28T00:31:55Z MEMBER

@observingClouds - I had forgotten the upsample tests were in test_dataarray.py. That seems like a better place to test this functionality. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: resample methods with tolerance 403462155
457963623 https://github.com/pydata/xarray/pull/2716#issuecomment-457963623 https://api.github.com/repos/pydata/xarray/issues/2716 MDEyOklzc3VlQ29tbWVudDQ1Nzk2MzYyMw== observingClouds 43613877 2019-01-27T23:16:58Z 2019-01-27T23:24:46Z CONTRIBUTOR

Sure @jhamman, I'll add some tests. However, I thought the test should rather go into test_dataarray.py than test_missing.py, because this is an improvement to resample/_upsample?

Something like ```python def test_upsample_tolerance(self): # Test tolerance keyword for upsample methods bfill, pad, nearest times = pd.date_range('2000-01-01', freq='1D', periods=2) times_upsampled = pd.date_range('2000-01-01', freq='6H', periods=5) array = DataArray(np.arange(2), [('time', times)])

    # Forward fill
    actual = array.resample(time='6H').ffill(tolerance='12H')
    expected = DataArray([0., 0., 0., np.nan, 1.],
                         [('time', times_upsampled)])
    assert_identical(expected, actual)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: resample methods with tolerance 403462155
457852456 https://github.com/pydata/xarray/pull/2716#issuecomment-457852456 https://api.github.com/repos/pydata/xarray/issues/2716 MDEyOklzc3VlQ29tbWVudDQ1Nzg1MjQ1Ng== jhamman 2443309 2019-01-26T18:08:49Z 2019-01-26T18:08:49Z MEMBER

Thanks @observingClouds - At first glance, this seems right but we'll want some tests to confirm. You'll probably want to put these in test_missing.py. That's where the existing tests for bfill/pad/etc are so should be easy to extend for this feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: resample methods with tolerance 403462155

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);