issue_comments

Table actions

13 rows where issue = 403458737 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix CRS being WKT instead of PROJ.4 · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
472137075 https://github.com/pydata/xarray/pull/2715#issuecomment-472137075 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ3MjEzNzA3NQ== shoyer 1217238 2019-03-12T18:57:44Z 2019-03-12T18:57:44Z MEMBER

Hopefully quite soon! see https://github.com/pydata/xarray/pull/2777 for current status

On Tue, Mar 12, 2019 at 10:31 AM David Hoese notifications@github.com wrote:

@shoyer https://github.com/shoyer Any idea when a 0.11.4 or 0.12 will be released? I'm trying to work around some other rasterio bugs and would like to remove the restriction on the rasterio version used in my CI tests, but that requires this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2715#issuecomment-472102830, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1hs0lknMUSnOP9A_Qw0124V8HZllks5vV-SGgaJpZM4aUQen . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
472102830 https://github.com/pydata/xarray/pull/2715#issuecomment-472102830 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ3MjEwMjgzMA== djhoese 1828519 2019-03-12T17:31:50Z 2019-03-12T17:31:50Z CONTRIBUTOR

@shoyer Any idea when a 0.11.4 or 0.12 will be released? I'm trying to work around some other rasterio bugs and would like to remove the restriction on the rasterio version used in my CI tests, but that requires this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
461099466 https://github.com/pydata/xarray/pull/2715#issuecomment-461099466 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MTA5OTQ2Ng== shoyer 1217238 2019-02-06T16:56:17Z 2019-02-06T16:56:17Z MEMBER

thanks David, that looks great

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
461097743 https://github.com/pydata/xarray/pull/2715#issuecomment-461097743 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MTA5Nzc0Mw== djhoese 1828519 2019-02-06T16:52:06Z 2019-02-06T16:52:06Z CONTRIBUTOR

@shoyer Added something to the whats-new. Let me know if anything needs changing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
458259755 https://github.com/pydata/xarray/pull/2715#issuecomment-458259755 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ1ODI1OTc1NQ== pep8speaks 24736507 2019-01-28T19:05:21Z 2019-02-06T16:49:02Z NONE

Hello @djhoese! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on February 06, 2019 at 16:49 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
461094509 https://github.com/pydata/xarray/pull/2715#issuecomment-461094509 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MTA5NDUwOQ== shoyer 1217238 2019-02-06T16:43:39Z 2019-02-06T16:43:39Z MEMBER

This PR isn't changing any functionality. It is making the same functionality available with newer versions of rasterio.

OK, good point. I do still try to lean towards adding notes about bug fixes in "what's new" but it isn't strictly required.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
461084264 https://github.com/pydata/xarray/pull/2715#issuecomment-461084264 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MTA4NDI2NA== djhoese 1828519 2019-02-06T16:17:41Z 2019-02-06T16:17:41Z CONTRIBUTOR

@dcherian @shoyer This PR isn't changing any functionality. It is making the same functionality available with newer versions of rasterio.

There are discussions going on regarding changing the behavior: https://github.com/pydata/xarray/issues/2723

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
461080045 https://github.com/pydata/xarray/pull/2715#issuecomment-461080045 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MTA4MDA0NQ== shoyer 1217238 2019-02-06T16:06:58Z 2019-02-06T16:06:58Z MEMBER

Does this need a whats-new entry?

Yes, I would recommend that here -- especially for cases where we're changing behavior without a deprecation cycle (which is sometime the best path forward)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
460745460 https://github.com/pydata/xarray/pull/2715#issuecomment-460745460 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ2MDc0NTQ2MA== dcherian 2448579 2019-02-05T18:16:48Z 2019-02-05T18:16:48Z MEMBER

Does this need a whats-new entry?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
459036333 https://github.com/pydata/xarray/pull/2715#issuecomment-459036333 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ1OTAzNjMzMw== fmaussion 10050469 2019-01-30T17:35:40Z 2019-01-30T17:35:40Z MEMBER

I'm going to merge this tomorrow unless there are further concerns

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
458260485 https://github.com/pydata/xarray/pull/2715#issuecomment-458260485 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ1ODI2MDQ4NQ== djhoese 1828519 2019-01-28T19:07:24Z 2019-01-28T19:07:24Z CONTRIBUTOR

@fmaussion Done. And I merged @snowman2's suggestion and fixed the indent (I'm guessing github's editor made it difficult to see but it was off by one indentation).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
458257810 https://github.com/pydata/xarray/pull/2715#issuecomment-458257810 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ1ODI1NzgxMA== fmaussion 10050469 2019-01-28T19:00:17Z 2019-01-28T19:00:17Z MEMBER

can your merge from master? The failing tests should be solved by https://github.com/pydata/xarray/pull/2720

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737
457849358 https://github.com/pydata/xarray/pull/2715#issuecomment-457849358 https://api.github.com/repos/pydata/xarray/issues/2715 MDEyOklzc3VlQ29tbWVudDQ1Nzg0OTM1OA== sgillies 33697 2019-01-26T17:30:22Z 2019-01-26T21:52:52Z NONE

@djhoese sorry for the inconvenience! I didn't consider the change in rasterio 1.0.14 to be an API change because the behavior of CRS.from_string(crs.to_string()) was not changed. I should have looked around for more usage like that in xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CRS being WKT instead of PROJ.4 403458737

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);