issue_comments

Table actions

4 rows where issue = 402678943 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Quarter offset support for cftime · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457176315 https://github.com/pydata/xarray/pull/2702#issuecomment-457176315 https://api.github.com/repos/pydata/xarray/issues/2702 MDEyOklzc3VlQ29tbWVudDQ1NzE3NjMxNQ== pep8speaks 24736507 2019-01-24T12:15:07Z 2019-01-27T21:35:40Z NONE

Hello @jwenfai! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on January 27, 2019 at 21:35 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset support for cftime 402678943
457954885 https://github.com/pydata/xarray/pull/2702#issuecomment-457954885 https://api.github.com/repos/pydata/xarray/issues/2702 MDEyOklzc3VlQ29tbWVudDQ1Nzk1NDg4NQ== spencerkclark 6628425 2019-01-27T21:14:41Z 2019-01-27T21:14:41Z MEMBER

Sorry @jwenfai, things still don't look quite right (we should only see commits related to the addition of quarterly offsets here). If it's easier, feel free to start fresh from a new PR.

seems like the failing checks are the same as the ones affecting the resample pull request.

As @shoyer mentioned in #2593, the tests should be fixed if you merge the latest master branch, now that #2720 has been merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset support for cftime 402678943
457953081 https://github.com/pydata/xarray/pull/2702#issuecomment-457953081 https://api.github.com/repos/pydata/xarray/issues/2702 MDEyOklzc3VlQ29tbWVudDQ1Nzk1MzA4MQ== jwenfai 8708062 2019-01-27T20:50:58Z 2019-01-27T20:50:58Z CONTRIBUTOR

I rebased, seems like the failing checks are the same as the ones affecting the resample pull request.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset support for cftime 402678943
457923434 https://github.com/pydata/xarray/pull/2702#issuecomment-457923434 https://api.github.com/repos/pydata/xarray/issues/2702 MDEyOklzc3VlQ29tbWVudDQ1NzkyMzQzNA== spencerkclark 6628425 2019-01-27T14:41:17Z 2019-01-27T14:41:17Z MEMBER

@jwenfai at first glance this looks pretty good. Would you mind rebasing this off of the current master branch of xarray (rather than your resampling branch)? Then I'll give it a more careful review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Quarter offset support for cftime 402678943

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);