issue_comments

Table actions

8 rows where issue = 40225000 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Get ride of "noncoordinates" as a name? · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
56319187 https://github.com/pydata/xarray/issues/212#issuecomment-56319187 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU2MzE5MTg3 shoyer 1217238 2014-09-22T00:55:22Z 2014-09-22T00:55:22Z MEMBER

This has been resolved per my last comment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
55996092 https://github.com/pydata/xarray/issues/212#issuecomment-55996092 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU1OTk2MDky shoyer 1217238 2014-09-18T05:20:55Z 2014-09-18T05:20:55Z MEMBER

@akleeman What do you think of removing access to the underlying array of xray.Variable objects entirely from the public dataset API? I think that is my preference... nobody really wants to work with those objects, anyways.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54585971 https://github.com/pydata/xarray/issues/212#issuecomment-54585971 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTg1OTcx shoyer 1217238 2014-09-05T05:17:03Z 2014-09-05T05:17:03Z MEMBER

New proposal... don't even bother renaming Variable and Coordinate, but switch Dataset.variables to Dataset.arrays and DataArray.variable to DataArray.array. Really, I just want to eliminate the confusing Dataset attribute... and arrays is shorter anyways.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54565020 https://github.com/pydata/xarray/issues/212#issuecomment-54565020 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTY1MDIw shoyer 1217238 2014-09-05T00:40:59Z 2014-09-05T00:40:59Z MEMBER

I guess this is coming full circle back to the name XArray now...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54564724 https://github.com/pydata/xarray/issues/212#issuecomment-54564724 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTY0NzI0 shoyer 1217238 2014-09-05T00:36:57Z 2014-09-05T00:38:17Z MEMBER

How about calling the arrays in a Dataset "store arrays" or just "arrays" for short? - Variable -> StoreArray - Coordinate -> IndexArray - Dataset.variables -> Dataset.arrays - DataArray.variable -> DataArray.array

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54563860 https://github.com/pydata/xarray/issues/212#issuecomment-54563860 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTYzODYw shoyer 1217238 2014-09-05T00:24:39Z 2014-09-05T00:25:15Z MEMBER

I don't think it's that terrible to be cryptic with the name for the xray.Variable object, because this object isn't really part of the public API. But I do agree that the connection with netCDF naming conventions is nice.

Also, to clarify, I was thinking of only identifying non-coordinates as "variables" in Dataset.__repr__. I agree that the property ds.variables should not be reused for something other than what it currently is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54560323 https://github.com/pydata/xarray/issues/212#issuecomment-54560323 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTYwMzIz akleeman 514053 2014-09-04T23:35:26Z 2014-09-04T23:35:26Z CONTRIBUTOR

I personally am not familiar with pandas.Block objects, so I find the name uniformative. That combined with the fact that renaming Variable to Block would break alignment with netCDF naming conventions (so confuse users coming from that background) makes me hesitant about the change. I think I'd be more excited about finding a better name for noncoordinates (fields? ) instead of renaming variables (which would also cause non-backwards compatibility)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000
54549741 https://github.com/pydata/xarray/issues/212#issuecomment-54549741 https://api.github.com/repos/pydata/xarray/issues/212 MDEyOklzc3VlQ29tbWVudDU0NTQ5NzQx shoyer 1217238 2014-09-04T21:43:00Z 2014-09-04T21:43:11Z MEMBER

I'm now thinking that I would like to rename the current Variable and Coordinate objects to Block and IndexBlock. The name is borrowed from the pandas.Block object which they resemble. The main distinction from pandas is that our blocks have a bit more associated metadata (dims, attrs and encoding). Thoughts?

Once we rename variables to blocks (at least for the public API), we can safely use the name "variables" in place of "noncoordinates". DataStores should also probably switch to calling their contents "blocks" instead of "variables" (cc @akleeman).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Get ride of "noncoordinates" as a name? 40225000

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);