issue_comments

Table actions

where issue = 400678645 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: issue

user 1

  • shoyer · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
456205288 https://github.com/pydata/xarray/pull/2690#issuecomment-456205288 https://api.github.com/repos/pydata/xarray/issues/2690 MDEyOklzc3VlQ29tbWVudDQ1NjIwNTI4OA== shoyer 1217238 2019-01-21T21:38:05Z 2019-01-21T21:38:05Z MEMBER

Maybe having a simple example available under just xarray.testing.dummy_dataset() is a good idea after all. If we do ever want to change it for xarray's own testing purposes, that would be quite easy.

That said... if we're going to emesh this in our API lets at least think a little bit to make sure we cover most of the special cases we care about. I think we cover most of the dtypes we care about, but let's also add at least: - Some global attributes - A scalar data variable (it's easy to forget about these)

Anything else?

We might also consider tweaking the names -- dim1, dim2 and dim3 is not very descriptive. Even x, y and z would be better.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add create_test_data to public testing API 400678645
456041072 https://github.com/pydata/xarray/pull/2690#issuecomment-456041072 https://api.github.com/repos/pydata/xarray/issues/2690 MDEyOklzc3VlQ29tbWVudDQ1NjA0MTA3Mg== shoyer 1217238 2019-01-21T11:24:56Z 2019-01-21T11:24:56Z MEMBER

I think putting an example that can be copied/pasted somewhere on the docs in the "extending xarray" section would be a nice way to solve this. On Mon, Jan 21, 2019 at 11:18 AM Tom Nicholas notifications@github.com wrote:

Why not just encourage users to copy/paste the helper function into their own codebases?

Just because they aren't going to know it exists unless we put it in a public place I suppose?

Happy to do any of those things, I just think that having some kind of public function/copyable code example etc is a simple thing for us to do that will make it just a bit easier for users who want to build upon xarray.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2690#issuecomment-456039039, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1vAzMMaKanBeW4AkUylnB7YqMg4Jks5vFaHogaJpZM4aHs0n . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add create_test_data to public testing API 400678645
455826431 https://github.com/pydata/xarray/pull/2690#issuecomment-455826431 https://api.github.com/repos/pydata/xarray/issues/2690 MDEyOklzc3VlQ29tbWVudDQ1NTgyNjQzMQ== shoyer 1217238 2019-01-20T00:21:09Z 2019-01-20T00:21:09Z MEMBER

Why not just encourage users to copy/paste the helper function into their own codebases? This seems like a pretty good use case for copy/paste.

Otherwise -- maybe we should think a little more carefully about what to include on the result. Or require explicitly providing a name for the desired dataset structure? E.g., xarray.testing.dummy_dataset('some_name')

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add create_test_data to public testing API 400678645
455593215 https://github.com/pydata/xarray/pull/2690#issuecomment-455593215 https://api.github.com/repos/pydata/xarray/issues/2690 MDEyOklzc3VlQ29tbWVudDQ1NTU5MzIxNQ== shoyer 1217238 2019-01-18T15:53:13Z 2019-01-18T15:53:13Z MEMBER

I am slightly reluctant about this because it would mean effectively freezing the output of this helper function. I guess that would probably be OK, but the design was never quite fully considered!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add create_test_data to public testing API 400678645

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);