issue_comments

Table actions

3 rows where issue = 399042126 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • NaT tests need to be fixed on master · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
454466287 https://github.com/pydata/xarray/issues/2673#issuecomment-454466287 https://api.github.com/repos/pydata/xarray/issues/2673 MDEyOklzc3VlQ29tbWVudDQ1NDQ2NjI4Nw== shoyer 1217238 2019-01-15T16:54:56Z 2019-01-15T16:54:56Z MEMBER

Well, we might as well keep the filter so we don't see the warning with old NumPy versions. Though I agree, we clearly should not have ignored it! On Tue, Jan 15, 2019 at 6:16 PM Deepak Cherian notifications@github.com wrote:

Can we remove the warnings filter in the line above your change? Seems like it filtered the warning about this particular issue!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2673#issuecomment-454451484, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1sq8rZpjZs3FzLmYVwf_Ok5I86TDks5vDf7EgaJpZM4Z_m2a . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NaT tests need to be fixed on master 399042126
454451484 https://github.com/pydata/xarray/issues/2673#issuecomment-454451484 https://api.github.com/repos/pydata/xarray/issues/2673 MDEyOklzc3VlQ29tbWVudDQ1NDQ1MTQ4NA== dcherian 2448579 2019-01-15T16:16:03Z 2019-01-15T16:16:03Z MEMBER

Can we remove the warnings filter in the line above your change? Seems like it filtered the warning about this particular issue!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NaT tests need to be fixed on master 399042126
454139673 https://github.com/pydata/xarray/issues/2673#issuecomment-454139673 https://api.github.com/repos/pydata/xarray/issues/2673 MDEyOklzc3VlQ29tbWVudDQ1NDEzOTY3Mw== shoyer 1217238 2019-01-14T19:55:11Z 2019-01-14T19:55:11Z MEMBER

We might just be able to switch these to use np.testing.assert_equal() (though I'm not sure if it handles NaT properly yet).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NaT tests need to be fixed on master 399042126

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);