issue_comments

Table actions

2 rows where issue = 398107776 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Dataset.from_dataframe will produce a FutureWarning for DatetimeTZ data · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
569819509 https://github.com/pydata/xarray/issues/2666#issuecomment-569819509 https://api.github.com/repos/pydata/xarray/issues/2666 MDEyOklzc3VlQ29tbWVudDU2OTgxOTUwOQ== shoyer 1217238 2019-12-30T22:51:36Z 2019-12-30T22:51:55Z MEMBER

Just FYI, we're potentially enforcing this deprecation in pandas-dev/pandas#30563 (which would be included in a pandas release in a week or two). Is that likely to cause problems for xarray users?

I don't think so. Xarray users have been seeing this warning for a while, so they should expect something will change.

Also, I don't think there are that many users using DatetimeTZ in xarray.

And there are a couple places that need updating, even with a dtypes argument to let the user specify things. We also hit this via Dataset.__setitem__

I think this is basically the same change. Is there a full example of the behavior that you are worried about?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.from_dataframe will produce a FutureWarning for DatetimeTZ data 398107776
453356449 https://github.com/pydata/xarray/issues/2666#issuecomment-453356449 https://api.github.com/repos/pydata/xarray/issues/2666 MDEyOklzc3VlQ29tbWVudDQ1MzM1NjQ0OQ== shoyer 1217238 2019-01-11T02:54:32Z 2019-01-11T02:54:32Z MEMBER

I'm open to suggestions here, especially from users who use DatetimeTZ data in pandas.

As noted in https://github.com/pandas-dev/pandas/issues/24716, I think the cleanest solution is probably to add a dtypes argument to from_dataframe, to allow users to specify their own desired dtypes for pandas -> numpy coercion.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.from_dataframe will produce a FutureWarning for DatetimeTZ data 398107776

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);