issue_comments

Table actions

3 rows where issue = 396008054 and user = 291576 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • WeatherGod · 3 ✖

issue 1

  • Change an `==` to an `is`. Fix tests so that this won't happen again. · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
451626366 https://github.com/pydata/xarray/pull/2648#issuecomment-451626366 https://api.github.com/repos/pydata/xarray/issues/2648 MDEyOklzc3VlQ29tbWVudDQ1MTYyNjM2Ng== WeatherGod 291576 2019-01-05T04:18:50Z 2019-01-05T04:18:50Z CONTRIBUTOR

I completely forgotten about that little quirk of cpython. I try to ignore implementation details like that. Heck, I still don't fully trust dictionaries to be ordered!

I removed the WIP. We can deal with the concat dim default object separately, including turning it into a ReprObject (not exactly sure what the advantage of it is over just using the string, but, meh).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change an `==` to an `is`. Fix tests so that this won't happen again. 396008054
451583970 https://github.com/pydata/xarray/pull/2648#issuecomment-451583970 https://api.github.com/repos/pydata/xarray/issues/2648 MDEyOklzc3VlQ29tbWVudDQ1MTU4Mzk3MA== WeatherGod 291576 2019-01-04T22:12:44Z 2019-01-04T22:12:44Z CONTRIBUTOR

Is the following statement True or False: "The user should be allowed to explicitly declare that they want the concatenation dimension to be inferred by passing a keyword argument". If this is True, then you need to test equivalence. If it is False, then there is nothing more I need to do for the PR, as changing this to use a ReprObject is orthogonal to these changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change an `==` to an `is`. Fix tests so that this won't happen again. 396008054
451581103 https://github.com/pydata/xarray/pull/2648#issuecomment-451581103 https://api.github.com/repos/pydata/xarray/issues/2648 MDEyOklzc3VlQ29tbWVudDQ1MTU4MTEwMw== WeatherGod 291576 2019-01-04T22:00:10Z 2019-01-04T22:00:10Z CONTRIBUTOR

ok, so we use the ReprObject for the default, and then test if concat_dim is of type `ReprObject and then test its equivalance?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change an `==` to an `is`. Fix tests so that this won't happen again. 396008054

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);