issue_comments

Table actions

3 rows where issue = 393978873 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Add flake check to travis · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
450530067 https://github.com/pydata/xarray/pull/2632#issuecomment-450530067 https://api.github.com/repos/pydata/xarray/issues/2632 MDEyOklzc3VlQ29tbWVudDQ1MDUzMDA2Nw== shoyer 1217238 2018-12-30T00:11:04Z 2018-12-30T00:11:04Z MEMBER

If someone else can figure out how to setup these checks to run with another CI service that would be fantastic, but this is definitely an improvement over nothing at all.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add flake check to travis 393978873
449823225 https://github.com/pydata/xarray/pull/2632#issuecomment-449823225 https://api.github.com/repos/pydata/xarray/issues/2632 MDEyOklzc3VlQ29tbWVudDQ0OTgyMzIyNQ== max-sixty 5635139 2018-12-25T08:26:35Z 2018-12-25T18:45:21Z MEMBER

I tend to agree on the differentiation between code tests and formatting tests.

But I think setting up CircleCI / Azure might be a lot of lift for just the ~CI~ flake check? Do people still have patience for Stickler?

I've at least added it as a separate check in Travis, though that doesn't show in GH

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add flake check to travis 393978873
449818503 https://github.com/pydata/xarray/pull/2632#issuecomment-449818503 https://api.github.com/repos/pydata/xarray/issues/2632 MDEyOklzc3VlQ29tbWVudDQ0OTgxODUwMw== fujiisoup 6815844 2018-12-25T07:45:23Z 2018-12-25T07:45:23Z MEMBER

Thanks, @max-sixty. I personally like to have a separate CI to check pep8 violation, so that we can easily distinguish whether the tests or pep8 fail by the green check in the bottom.

Do you have any idea about the ci for pep8? Or we can simply use the general ci such as circle ci?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add flake check to travis 393978873

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);