issue_comments

Table actions

5 rows where issue = 388977754 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Close files when CachingFileManager is garbage collected · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
445504068 https://github.com/pydata/xarray/pull/2595#issuecomment-445504068 https://api.github.com/repos/pydata/xarray/issues/2595 MDEyOklzc3VlQ29tbWVudDQ0NTUwNDA2OA== pep8speaks 24736507 2018-12-09T01:53:54Z 2018-12-23T19:51:03Z NONE

Hello @shoyer! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on December 23, 2018 at 19:51 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Close files when CachingFileManager is garbage collected 388977754
449217005 https://github.com/pydata/xarray/pull/2595#issuecomment-449217005 https://api.github.com/repos/pydata/xarray/issues/2595 MDEyOklzc3VlQ29tbWVudDQ0OTIxNzAwNQ== shoyer 1217238 2018-12-21T02:12:14Z 2018-12-21T02:12:14Z MEMBER

OK, I'm actually going to merge soon (and issue the 0.11.1 release) unless I hear any objections...

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Close files when CachingFileManager is garbage collected 388977754
447517019 https://github.com/pydata/xarray/pull/2595#issuecomment-447517019 https://api.github.com/repos/pydata/xarray/issues/2595 MDEyOklzc3VlQ29tbWVudDQ0NzUxNzAxOQ== shoyer 1217238 2018-12-15T00:20:40Z 2018-12-15T00:20:40Z MEMBER

Yeah, it's not really any additional trouble. I plan to include this in a v0.11.1 release, which will be the last release to support Python 2. On Fri, Dec 14, 2018 at 4:12 PM Joe Hamman notifications@github.com wrote:

@jhamman commented on this pull request.

In xarray/backends/locks.py https://github.com/pydata/xarray/pull/2595#discussion_r241925201:

  • Includes backwards compatibility hacks for old versions of Python, dask
  • and dask-distributed.
  • """
  • if blocking:

  • no arguments needed

  • return lock.acquire()
  • elif DistributedLock is not None and isinstance(lock, DistributedLock):

  • distributed.Lock doesn't support the blocking argument yet:

  • https://github.com/dask/distributed/pull/2412

  • return lock.acquire(timeout=0)
  • else:

  • "blocking" keyword argument not supported for:

  • - threading.Lock on Python 2.

  • - dask.SerializableLock with dask v1.0.0 or earlier.

  • - multiprocessing.Lock calls the argument "block" instead.

  • return lock.acquire(blocking)

Given the date, do you think its useful here to consider this Python 2 work around? I guess its the same work-around as the dask/multiprocessing issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2595#pullrequestreview-185327940, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1iwt7OmehxX6coNie-LtSI3YJnhhks5u5D57gaJpZM4ZJ6GX . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Close files when CachingFileManager is garbage collected 388977754
446860434 https://github.com/pydata/xarray/pull/2595#issuecomment-446860434 https://api.github.com/repos/pydata/xarray/issues/2595 MDEyOklzc3VlQ29tbWVudDQ0Njg2MDQzNA== shoyer 1217238 2018-12-13T06:46:17Z 2018-12-13T06:46:17Z MEMBER

@pydata/xarray It would be great if someone else could take a look at this, though certainly thread-safety and garbage collection are slightly painful concepts to think deeply about. If nobody reviews this, I will probably self-merge in a few days.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Close files when CachingFileManager is garbage collected 388977754
446407628 https://github.com/pydata/xarray/pull/2595#issuecomment-446407628 https://api.github.com/repos/pydata/xarray/issues/2595 MDEyOklzc3VlQ29tbWVudDQ0NjQwNzYyOA== shoyer 1217238 2018-12-11T23:51:44Z 2018-12-11T23:51:44Z MEMBER

Of course everything runs fine either on my laptop (Macbook) or work machine (Linux). I wonder what's going on with Travis-CI here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Close files when CachingFileManager is garbage collected 388977754

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);