issue_comments

Table actions

4 rows where issue = 387892184 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Deprecated autoclose option · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
444599941 https://github.com/pydata/xarray/issues/2592#issuecomment-444599941 https://api.github.com/repos/pydata/xarray/issues/2592 MDEyOklzc3VlQ29tbWVudDQ0NDU5OTk0MQ== pwolfram 4295853 2018-12-05T18:54:10Z 2018-12-05T18:54:10Z CONTRIBUTOR

Thanks @jhamman! @xylar, I'm thinking file_cache_maxsize=1200 would be a good default (100 years of monthly files) that could be modified via the config files we use.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecated autoclose option 387892184
444599192 https://github.com/pydata/xarray/issues/2592#issuecomment-444599192 https://api.github.com/repos/pydata/xarray/issues/2592 MDEyOklzc3VlQ29tbWVudDQ0NDU5OTE5Mg== jhamman 2443309 2018-12-05T18:52:00Z 2018-12-05T18:52:00Z MEMBER

@pwolfram - Thats right. We currently default to a fairly small number (128):

https://github.com/pydata/xarray/blob/3ae93ac31ce122fc10b089f3b92b8c20e8b218c9/xarray/core/options.py#L18

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecated autoclose option 387892184
444597829 https://github.com/pydata/xarray/issues/2592#issuecomment-444597829 https://api.github.com/repos/pydata/xarray/issues/2592 MDEyOklzc3VlQ29tbWVudDQ0NDU5NzgyOQ== pwolfram 4295853 2018-12-05T18:47:55Z 2018-12-05T18:47:55Z CONTRIBUTOR

@jhamman, LRU is much better. The api-change on our size is to replace autoclose=True with file_cache_maxsize=A_REASONABLE_BIG_NUMBER, correct?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecated autoclose option 387892184
444597103 https://github.com/pydata/xarray/issues/2592#issuecomment-444597103 https://api.github.com/repos/pydata/xarray/issues/2592 MDEyOklzc3VlQ29tbWVudDQ0NDU5NzEwMw== jhamman 2443309 2018-12-05T18:45:38Z 2018-12-05T18:45:38Z MEMBER

@pwolfram - this option was deprecated in the last release following https://github.com/pydata/xarray/pull/2261. Xarray now uses a LRU cache to manage open file handles. This can be configured via a global option: xarray.set_options(file_cache_maxsize=...).

If I recall correctly, you were part of the early LRU cache conversations.

release notes on the subject: http://xarray.pydata.org/en/stable/whats-new.html#breaking-changes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecated autoclose option 387892184

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);