issue_comments

Table actions

8 rows where issue = 387732534 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix h5netcdf saving scalars with filters or chunks · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
446098869 https://github.com/pydata/xarray/pull/2591#issuecomment-446098869 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NjA5ODg2OQ== shoyer 1217238 2018-12-11T07:24:39Z 2018-12-11T07:24:39Z MEMBER

thanks!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
445787568 https://github.com/pydata/xarray/pull/2591#issuecomment-445787568 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NTc4NzU2OA== spencerkclark 6628425 2018-12-10T11:43:36Z 2018-12-10T11:43:36Z MEMBER

How about whats-new.rst, do you want me to fill in something there?

Yes, I think it would make sense to document this change under the "Bug fixes" heading.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
445786351 https://github.com/pydata/xarray/pull/2591#issuecomment-445786351 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NTc4NjM1MQ== mraspaud 167802 2018-12-10T11:38:24Z 2018-12-10T11:38:24Z CONTRIBUTOR

Ok good, I'll let this run it's course then. How about whats-new.rst, do you want me to fill in something there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
445781253 https://github.com/pydata/xarray/pull/2591#issuecomment-445781253 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NTc4MTI1Mw== spencerkclark 6628425 2018-12-10T11:18:11Z 2018-12-10T11:18:11Z MEMBER

Ok travis seems to pass, how about appveyor ? There are many time encoding errors, should it be so ?

I believe those are unrelated to this PR. There was a series of bug fix releases of cftime following the initial 1.0.3 release (the failing build here uses 1.0.3). I think with the latest one (1.0.3.4), released a few days ago, things should be back to normal (as evidenced by the build passing in #2596).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
445739994 https://github.com/pydata/xarray/pull/2591#issuecomment-445739994 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NTczOTk5NA== mraspaud 167802 2018-12-10T09:01:49Z 2018-12-10T09:01:49Z CONTRIBUTOR

Ok travis seems to pass, how about appveyor ? There are many time encoding errors, should it be so ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
444842759 https://github.com/pydata/xarray/pull/2591#issuecomment-444842759 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NDg0Mjc1OQ== mraspaud 167802 2018-12-06T11:36:35Z 2018-12-06T11:36:35Z CONTRIBUTOR

Am I right in thinking the failing travis and appveyor build aren't my doing ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
444469807 https://github.com/pydata/xarray/pull/2591#issuecomment-444469807 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NDQ2OTgwNw== mraspaud 167802 2018-12-05T12:33:58Z 2018-12-05T12:33:58Z CONTRIBUTOR

I'm not sure if I need to document anything as this is just a bugfix ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534
444467097 https://github.com/pydata/xarray/pull/2591#issuecomment-444467097 https://api.github.com/repos/pydata/xarray/issues/2591 MDEyOklzc3VlQ29tbWVudDQ0NDQ2NzA5Nw== pep8speaks 24736507 2018-12-05T12:22:45Z 2018-12-05T12:22:45Z NONE

Hello @mraspaud! Thanks for submitting the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix h5netcdf saving scalars with filters or chunks 387732534

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);