issue_comments

Table actions

6 rows where issue = 387673324 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • use keep_attrs in binary operations II · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
446866434 https://github.com/pydata/xarray/pull/2590#issuecomment-446866434 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0Njg2NjQzNA== MBlaschek 8898319 2018-12-13T07:16:23Z 2018-12-13T07:16:23Z CONTRIBUTOR

Cool. I will keep using Xarray. Thanks for the great work

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324
446666682 https://github.com/pydata/xarray/pull/2590#issuecomment-446666682 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0NjY2NjY4Mg== shoyer 1217238 2018-12-12T17:11:45Z 2018-12-12T17:11:45Z MEMBER

Thank @MBlaschek -- we appreciate your help here! It does get easier for next time, I promise :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324
446663592 https://github.com/pydata/xarray/pull/2590#issuecomment-446663592 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0NjY2MzU5Mg== dcherian 2448579 2018-12-12T17:03:05Z 2018-12-12T17:03:05Z MEMBER

Thanks, @MBlaschek. Looks great to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324
446546926 https://github.com/pydata/xarray/pull/2590#issuecomment-446546926 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0NjU0NjkyNg== MBlaschek 8898319 2018-12-12T10:57:46Z 2018-12-12T10:57:46Z CONTRIBUTOR

I hope that is all you guys wanted. It's kinda complicated for me to follow all these procedures to do really simple thing. I hope that helps and thanks for the inside into pull-requests. Please let me know if I can close it and be done with it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324
444424066 https://github.com/pydata/xarray/pull/2590#issuecomment-444424066 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0NDQyNDA2Ng== pep8speaks 24736507 2018-12-05T09:47:51Z 2018-12-07T09:40:11Z NONE

Hello @MBlaschek! Thanks for updating the PR.

Comment last updated on December 07, 2018 at 09:40 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324
444562863 https://github.com/pydata/xarray/pull/2590#issuecomment-444562863 https://api.github.com/repos/pydata/xarray/issues/2590 MDEyOklzc3VlQ29tbWVudDQ0NDU2Mjg2Mw== dcherian 2448579 2018-12-05T17:04:43Z 2018-12-05T17:07:30Z MEMBER

Thanks @MBlaschek. 1. You'll need to also add a note to doc/whats-new.rst. 2. Looks like there's trailing whitespace in test_variable.py that will need to be fixed.

EDIT: Looks like the tests aren't running because of this ImportError

ImportError while importing test module '/home/travis/build/pydata/xarray/xarray/tests/test_variable.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: xarray/tests/test_variable.py:27: in <module> from . import ( E ImportError: cannot import name 'set_options'

I think you need from xarray import set_options as in test_dataset.py. You can test this out locally using pytest. We have some documentation on contributing here: http://xarray.pydata.org/en/stable/contributing.html. Feel free to ask if you have questions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use keep_attrs in binary operations II 387673324

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);