issue_comments

Table actions

14 rows where issue = 387123860 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • added some logic to deal with rasterio objects in addition to filepaths · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508878081 https://github.com/pydata/xarray/pull/2589#issuecomment-508878081 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDUwODg3ODA4MQ== shoyer 1217238 2019-07-05T23:13:49Z 2019-07-05T23:13:49Z MEMBER

test_rasterio_vrt_network is failing in continuous integration tests, now: https://github.com/pydata/xarray/issues/3083

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
443974323 https://github.com/pydata/xarray/pull/2589#issuecomment-443974323 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0Mzk3NDMyMw== pep8speaks 24736507 2018-12-04T05:13:37Z 2018-12-23T18:24:25Z NONE

Hello @scottyhq! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on December 23, 2018 at 18:24 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
449531351 https://github.com/pydata/xarray/pull/2589#issuecomment-449531351 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0OTUzMTM1MQ== mrocklin 306380 2018-12-22T00:43:16Z 2018-12-22T00:43:16Z MEMBER

``` mrocklin@carbon:~$ conda search rasterio=1 Loading channels: done

Name Version Build Channel

rasterio 1.0.13 py27hc38cc03_0 pkgs/main
rasterio 1.0.13 py36hc38cc03_0 pkgs/main
rasterio 1.0.13 py37hc38cc03_0 pkgs/main
```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
449530939 https://github.com/pydata/xarray/pull/2589#issuecomment-449530939 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0OTUzMDkzOQ== mrocklin 306380 2018-12-22T00:38:34Z 2018-12-22T00:38:34Z MEMBER

For whatever reason the conda defaults channel hasn't been updated since 0.36 (Jun 14, 2016!).

It looks like @jjhelmus resolved this upstream . It seems like https://github.com/ContinuumIO/anaconda-issues is a good issue tracker to know :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
449523093 https://github.com/pydata/xarray/pull/2589#issuecomment-449523093 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0OTUyMzA5Mw== jjhelmus 1050278 2018-12-21T23:30:14Z 2018-12-21T23:30:14Z CONTRIBUTOR

rasterio 1.0.13 packages are now available in defaults for all supported platforms and python version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448747075 https://github.com/pydata/xarray/pull/2589#issuecomment-448747075 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODc0NzA3NQ== mrocklin 306380 2018-12-19T21:17:52Z 2018-12-19T21:17:52Z MEMBER

https://github.com/ContinuumIO/anaconda-issues/issues/10443

On Wed, Dec 19, 2018 at 4:14 PM Jonathan J. Helmus notifications@github.com wrote:

@jjhelmus https://github.com/jjhelmus is there a good way to report things like this other than pinging you directly?

Opening and issue in the anaconda-issues https://github.com/ContinuumIO/anaconda-issues repository is the best option at this time for requesting a package update.

I'm looking at updating the rasterio package in defaults this week. Something should be available by the end of the week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2589#issuecomment-448746048, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszMr1wxsC7gjEdyH3dfrDU5kig_LBks5u6qwugaJpZM4Y_8DQ . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448746048 https://github.com/pydata/xarray/pull/2589#issuecomment-448746048 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODc0NjA0OA== jjhelmus 1050278 2018-12-19T21:14:18Z 2018-12-19T21:14:18Z CONTRIBUTOR

@jjhelmus is there a good way to report things like this other than pinging you directly?

Opening and issue in the anaconda-issues repository is the best option at this time for requesting a package update.

I'm looking at updating the rasterio package in defaults this week. Something should be available by the end of the week.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448699184 https://github.com/pydata/xarray/pull/2589#issuecomment-448699184 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODY5OTE4NA== mrocklin 306380 2018-12-19T18:34:47Z 2018-12-19T18:34:47Z MEMBER

For whatever reason the conda defaults channel hasn't been updated since 0.36 (Jun 14, 2016!).

@jjhelmus is there a good way to report things like this other than pinging you directly? (which I'm more than happy to continue doing :))

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448696680 https://github.com/pydata/xarray/pull/2589#issuecomment-448696680 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODY5NjY4MA== shoyer 1217238 2018-12-19T18:26:25Z 2018-12-19T18:26:25Z MEMBER

OK, please update our installation page at docs/installing.rst, too. This should also definitely be mentioned in "what's new"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448686066 https://github.com/pydata/xarray/pull/2589#issuecomment-448686066 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODY4NjA2Ng== jhamman 2443309 2018-12-19T17:52:25Z 2018-12-19T17:52:25Z MEMBER

I'd be personally fine bumping our minimum version of rasterio to 1.0. There have been multiple minor releases since then so I would suggest the 1.0 version has stabilized by now.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448685064 https://github.com/pydata/xarray/pull/2589#issuecomment-448685064 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODY4NTA2NA== scottyhq 3924836 2018-12-19T17:49:19Z 2018-12-19T17:49:19Z MEMBER

I think the minimum rasterio version should be increased to 1.0. For whatever reason the conda defaults channel hasn't been updated since 0.36 (Jun 14, 2016!). There are many important changes in 1.0 and beyond, and those releases are available via both pip and conda-forge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448675165 https://github.com/pydata/xarray/pull/2589#issuecomment-448675165 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODY3NTE2NQ== shoyer 1217238 2018-12-19T17:18:53Z 2018-12-19T17:19:03Z MEMBER

These tests are failing on our "py36-rasterio-0.36" build, e.g., ``` def test_rasterio_vrt(self): import rasterio # tmp_file default crs is UTM: CRS({'init': 'epsg:32618'} with create_tmp_geotiff() as (tmp_file, expected): with rasterio.open(tmp_file) as src:

          with rasterio.vrt.WarpedVRT(src, crs='epsg:4326') as vrt:

E AttributeError: module 'rasterio' has no attribute 'vrt' ``` https://travis-ci.org/pydata/xarray/builds/469845498?utm_source=github_status&utm_medium=notification

Should we increase the minimum required version of rasterio or guard these imports?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
448416895 https://github.com/pydata/xarray/pull/2589#issuecomment-448416895 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0ODQxNjg5NQ== scottyhq 3924836 2018-12-18T23:57:08Z 2018-12-18T23:57:08Z MEMBER

thanks for the feedback @fmaussion, I think I've addressed your suggestions, let me know if anything else needs adjusting

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860
443974465 https://github.com/pydata/xarray/pull/2589#issuecomment-443974465 https://api.github.com/repos/pydata/xarray/issues/2589 MDEyOklzc3VlQ29tbWVudDQ0Mzk3NDQ2NQ== scottyhq 3924836 2018-12-04T05:14:26Z 2018-12-04T05:14:26Z MEMBER

Following up on https://github.com/dask/dask/issues/3255 @mrocklin, @shoyer, @jhamman 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   added some logic to deal with rasterio objects in addition to filepaths 387123860

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);