issue_comments

Table actions

6 rows where issue = 376116903 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Manually specify chunks in open_zarr · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
484536761 https://github.com/pydata/xarray/pull/2530#issuecomment-484536761 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ4NDUzNjc2MQ== dcherian 2448579 2019-04-18T14:35:21Z 2019-04-18T14:35:21Z MEMBER

Thanks @lilyminium!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
482697802 https://github.com/pydata/xarray/pull/2530#issuecomment-482697802 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ4MjY5NzgwMg== rabernat 1197350 2019-04-12T19:38:18Z 2019-04-12T19:38:18Z MEMBER

LGTM! Thanks for all your work @lilyminium!

Now that all tests are green, I'll leave this open for another day in case anyone else has comments and then merge.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
482404244 https://github.com/pydata/xarray/pull/2530#issuecomment-482404244 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ4MjQwNDI0NA== lilyminium 31115101 2019-04-12T01:47:17Z 2019-04-12T01:47:17Z CONTRIBUTOR

Hi @lilyminium - I appreciate your patience with this. I think we are almost there!

We have a few failing tests. Zarr is raising a ValueError: missing object_codec for object array. This is pretty old, so I don't think it's due to an upstream zarr change.

Do you have any idea what might be going on here? I haven't had time to dig deep into it.

Whoops, I think I was looking at the unicode dtype and forgot which branch I was in, then ran tests in the wrong environment... hopefully fixed now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
434809663 https://github.com/pydata/xarray/pull/2530#issuecomment-434809663 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQzNDgwOTY2Mw== pep8speaks 24736507 2018-10-31T19:04:12Z 2019-04-12T01:38:10Z NONE

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-12 01:38:10 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
481404969 https://github.com/pydata/xarray/pull/2530#issuecomment-481404969 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ4MTQwNDk2OQ== rabernat 1197350 2019-04-09T19:38:05Z 2019-04-09T19:38:05Z MEMBER

Hi @lilyminium - I appreciate your patience with this. I think we are almost there!

We have a few failing tests. Zarr is raising a ValueError: missing object_codec for object array. This is pretty old, so I don't think it's due to an upstream zarr change.

Do you have any idea what might be going on here? I haven't had time to dig deep into it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
449080622 https://github.com/pydata/xarray/pull/2530#issuecomment-449080622 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ0OTA4MDYyMg== rabernat 1197350 2018-12-20T17:47:39Z 2018-12-20T17:47:39Z MEMBER

This PR seems neglected. Sorry for that! Hope to find time to review it in the next few days.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);