issue_comments

Table actions

8 rows where issue = 373574495 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: issue

user 1

  • shoyer · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
436751105 https://github.com/pydata/xarray/issues/2505#issuecomment-436751105 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjc1MTEwNQ== shoyer 1217238 2018-11-07T19:38:39Z 2018-11-07T19:38:39Z MEMBER

Generally I always favor the most granular dependency specifications, but this seems like something conda-forge could decide as a matter of policy. If they don't want to rule on a general policy, then yes let's drop optional conda deps to match pypi.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436684494 https://github.com/pydata/xarray/issues/2505#issuecomment-436684494 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjY4NDQ5NA== shoyer 1217238 2018-11-07T16:25:52Z 2018-11-07T16:25:52Z MEMBER

I just tagged the release and uploaded it to pypi. RTD and conda forge should follow soon automatically.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
436497197 https://github.com/pydata/xarray/issues/2505#issuecomment-436497197 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNjQ5NzE5Nw== shoyer 1217238 2018-11-07T04:01:16Z 2018-11-07T04:01:16Z MEMBER

see https://github.com/pydata/xarray/pull/2548 for some minor reorganization of the release notes

On Tue, Nov 6, 2018 at 7:57 PM Joe Hamman notifications@github.com wrote:

I'm observing that our checklist seems to be complete. Are we blocked on any outstanding issues?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2505#issuecomment-436464907, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1n0lnPnS0XcLgOvEro2PN5JoGTIMks5usjAHgaJpZM4X4V2i . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
435622842 https://github.com/pydata/xarray/issues/2505#issuecomment-435622842 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNTYyMjg0Mg== shoyer 1217238 2018-11-03T21:38:17Z 2018-11-03T21:38:17Z MEMBER

Another deprecation cycle to finish would be the old resample() syntax.

I got started on this one...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
434477760 https://github.com/pydata/xarray/issues/2505#issuecomment-434477760 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzNDQ3Nzc2MA== shoyer 1217238 2018-10-30T21:31:58Z 2018-10-30T21:31:58Z MEMBER

Another deprecation cycle to finish would be the old resample() syntax.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433255897 https://github.com/pydata/xarray/issues/2505#issuecomment-433255897 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzI1NTg5Nw== shoyer 1217238 2018-10-26T01:22:26Z 2018-10-26T01:22:26Z MEMBER

@spencerkclark I also think this is probably a good idea. If you have time, it would be great if you could put together a PR to switch the behavior.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433235743 https://github.com/pydata/xarray/issues/2505#issuecomment-433235743 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzIzNTc0Mw== shoyer 1217238 2018-10-25T23:13:11Z 2018-10-25T23:13:11Z MEMBER

@spencerkclark and other climate scientists: should we switch the default behavior to use cftime for non-standard calendars in 0.11? (see https://github.com/pydata/xarray/issues/2437)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495
433096681 https://github.com/pydata/xarray/issues/2505#issuecomment-433096681 https://api.github.com/repos/pydata/xarray/issues/2505 MDEyOklzc3VlQ29tbWVudDQzMzA5NjY4MQ== shoyer 1217238 2018-10-25T15:28:38Z 2018-10-25T15:28:38Z MEMBER

Would it make sense to add a deprecation warning for Python2 users in this release (xref #1876). Chances are, 0.12 will come after Jan-2019 when we're slated to drop Python2 support.

I agree, this will probably be the last major xarray release with Python 2 support. But I don't think there's much to be gained by adding a warning -- Python 2 users know the end is near.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 0.11 release 373574495

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);