issue_comments

Table actions

where issue = 369803291 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 1 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
429903217 https://github.com/pydata/xarray/pull/2485#issuecomment-429903217 https://api.github.com/repos/pydata/xarray/issues/2485 MDEyOklzc3VlQ29tbWVudDQyOTkwMzIxNw== shoyer 1217238 2018-10-15T15:34:40Z 2018-10-15T15:34:40Z MEMBER

Just add a brief comment here summarizing this, e.g., "# no longer used as of pandas 0.23"

On Mon, Oct 15, 2018 at 5:36 AM Spencer Clark notifications@github.com wrote:

@spencerkclark commented on this pull request.

In xarray/coding/cftimeindex.py https://github.com/pydata/xarray/pull/2485#discussion_r225145820:

     return CFTimeIndex(other + np.array(self))

 def __sub__(self, other):
  • return CFTimeIndex(np.array(self) - other)
  • if isinstance(other, CFTimeIndex):
  • return pd.TimedeltaIndex(np.array(self) - np.array(other))
  • elif isinstance(other, pd.TimedeltaIndex):
  • return CFTimeIndex(np.array(self) - other.to_pytimedelta())
  • else:
  • return CFTimeIndex(np.array(self) - other) +
  • def _add_delta(self, deltas):

  • To support TimedeltaIndex + CFTimeIndex with older pandas versions

Yes, this method is not needed with recent versions of pandas. I think the change that eliminated the need for it was in this PR: pandas-dev/pandas#19895 https://github.com/pandas-dev/pandas/pull/19895, which I guess would have made it into pandas version 0.23.0.

I added it because of the failing test in the Windows 32-bit Python 2.7 build that used pandas version 0.22.0. Should I just mark the test as an expected failure for versions of pandas less than 0.23 and remove this private method?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2485#discussion_r225145820, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1iKDRM5Cgp8ODnM18-bYY1rqidWmks5ulH9dgaJpZM4Xaojb . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve arithmetic operations involving CFTimeIndexes and TimedeltaIndexes 369803291

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);