issue_comments

Table actions

8 rows where issue = 369673042 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Global option to always keep/discard attrs on operations · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
434134473 https://github.com/pydata/xarray/pull/2482#issuecomment-434134473 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzNDEzNDQ3Mw== shoyer 1217238 2018-10-30T01:01:17Z 2018-10-30T01:01:17Z MEMBER

Thanks @TomNicholas !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
429427849 https://github.com/pydata/xarray/pull/2482#issuecomment-429427849 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQyOTQyNzg0OQ== pep8speaks 24736507 2018-10-12T19:01:20Z 2018-10-29T15:19:05Z NONE

Hello @TomNicholas! Thanks for updating the PR.

Comment last updated on October 29, 2018 at 15:19 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
433628471 https://github.com/pydata/xarray/pull/2482#issuecomment-433628471 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMzYyODQ3MQ== spencerkclark 6628425 2018-10-27T15:06:35Z 2018-10-27T15:06:35Z MEMBER

@TomNicholas thanks, things look better now. Don't worry about the Appveyor failures; a new version of cftime (installed via pip on the Python 2 builds there) was just released and there is a bug they are still ironing out on a few platforms (including Windows): https://github.com/conda-forge/cftime-feedstock/pull/10, https://github.com/Unidata/cftime/pull/76. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
433623298 https://github.com/pydata/xarray/pull/2482#issuecomment-433623298 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMzYyMzI5OA== spencerkclark 6628425 2018-10-27T14:05:53Z 2018-10-27T14:05:53Z MEMBER

@TomNicholas it looks like the merge conflict in whats-new.rst is preventing the CI from running. I think if you sync with the latest master branch and resolve the conflict things should work properly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
433621969 https://github.com/pydata/xarray/pull/2482#issuecomment-433621969 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMzYyMTk2OQ== TomNicholas 35968931 2018-10-27T13:49:53Z 2018-10-27T13:49:53Z MEMBER

No idea why the CI test fails now - I literally changed one line, from class TestAttrRetention: to class TestAttrRetention(object):, and all tests pass on my local machine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
431099046 https://github.com/pydata/xarray/pull/2482#issuecomment-431099046 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMTA5OTA0Ng== shoyer 1217238 2018-10-18T17:41:43Z 2018-10-18T17:41:43Z MEMBER

@TomNicholas I'm not sure, but don't worry about cleaning up git history with rebase. We squash all commits before merging anyways, and GitHub's review tools work a little better when you don't rebase.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
431098280 https://github.com/pydata/xarray/pull/2482#issuecomment-431098280 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMTA5ODI4MA== TomNicholas 35968931 2018-10-18T17:39:24Z 2018-10-18T17:39:24Z MEMBER

I wanted to clean up my commits using git rebase, but when I tried git rebase -i I only had the choice to alter my last 5 commits to this branch, not all 8. I'm not sure if you know what I'm doing wrong there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042
431096301 https://github.com/pydata/xarray/pull/2482#issuecomment-431096301 https://api.github.com/repos/pydata/xarray/issues/2482 MDEyOklzc3VlQ29tbWVudDQzMTA5NjMwMQ== shoyer 1217238 2018-10-18T17:33:20Z 2018-10-18T17:33:20Z MEMBER

Unit tests and docs look good.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Global option to always keep/discard attrs on operations 369673042

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);