issue_comments

Table actions

7 rows where issue = 368004737 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association

user 1

  • shoyer · 7 ✖

issue 1

  • Add a GRIB backend via ECMWF cfgrib / ecCodes · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
430705904 https://github.com/pydata/xarray/pull/2476#issuecomment-430705904 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQzMDcwNTkwNA== shoyer 1217238 2018-10-17T16:54:00Z 2018-10-17T16:54:00Z MEMBER

Thanks @alexamici and ECMWF!

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 3,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
429663367 https://github.com/pydata/xarray/pull/2476#issuecomment-429663367 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyOTY2MzM2Nw== shoyer 1217238 2018-10-14T21:16:46Z 2018-10-14T21:16:46Z MEMBER

Do you usually keep the history of PRs as it is or do you prefer me to rebase?

We squash commits upon merging, so please leave things as is :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
429383251 https://github.com/pydata/xarray/pull/2476#issuecomment-429383251 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyOTM4MzI1MQ== shoyer 1217238 2018-10-12T16:26:42Z 2018-10-12T16:26:42Z MEMBER

Tests should be fixed if you merge in master now.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
428783424 https://github.com/pydata/xarray/pull/2476#issuecomment-428783424 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyODc4MzQyNA== shoyer 1217238 2018-10-11T01:09:08Z 2018-10-11T01:09:08Z MEMBER

@alexamici oops, we accidentally disabled most of our backend unit tests -- see https://github.com/pydata/xarray/pull/2479 for the fix.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
428388364 https://github.com/pydata/xarray/pull/2476#issuecomment-428388364 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyODM4ODM2NA== shoyer 1217238 2018-10-09T23:34:30Z 2018-10-09T23:34:30Z MEMBER

The v0.11 release still need more work (to complete deprecations), so it's at least a week or two out (probably more). I suspect we could get this PR ready together in time.

On Tue, Oct 9, 2018 at 3:59 PM Alessandro Amici notifications@github.com wrote:

@shoyer https://github.com/shoyer BTW what timeframe do you expect for the v0.11 release? And would you consider merging this Pull Request before the release, assuming that we do a cfgrib release with read support declared beta?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2476#issuecomment-428381697, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nCJOGlFSIEtL28sQ80GZqhzJ_Q2ks5ujSpVgaJpZM4XOXA8 . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
428231963 https://github.com/pydata/xarray/pull/2476#issuecomment-428231963 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyODIzMTk2Mw== shoyer 1217238 2018-10-09T15:12:41Z 2018-10-09T15:12:41Z MEMBER

The appropriate lock to use depends on cfgrid. Is the library thread-safe? If not, it's probably best to use a global (per process) lock.

pynio is probably the simplest example of how to write a new backend: https://github.com/pydata/xarray/blob/master/xarray/backends/pynio_.py

The main difference is that you should make use of CachingFileManager to add support for dask and opening many files at once. File managers make it possible to pickle a datastore, which is what we need to make dask-distirbuted work.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737
428036391 https://github.com/pydata/xarray/pull/2476#issuecomment-428036391 https://api.github.com/repos/pydata/xarray/issues/2476 MDEyOklzc3VlQ29tbWVudDQyODAzNjM5MQ== shoyer 1217238 2018-10-09T02:12:41Z 2018-10-09T02:12:41Z MEMBER

@alexamici great to see this!

I'm about to merge a refactor of xarray's backends for v0.11 in https://github.com/pydata/xarray/pull/2261. You'll need to refactor a little bit to accommodate this, but hopefully that should be straightforward. The new interface should be a little easier to use, especially for handling many files or dask-distributed support.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a GRIB backend via ECMWF cfgrib / ecCodes 368004737

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);