issue_comments

Table actions

5 rows where issue = 367410303 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Replace the last of unittest with pytest · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
427594908 https://github.com/pydata/xarray/pull/2467#issuecomment-427594908 https://api.github.com/repos/pydata/xarray/issues/2467 MDEyOklzc3VlQ29tbWVudDQyNzU5NDkwOA== shoyer 1217238 2018-10-06T18:09:56Z 2018-10-06T18:09:56Z MEMBER

Thanks Maximilian! On Sat, Oct 6, 2018 at 1:09 PM Maximilian Roos notifications@github.com wrote:

Merged #2467 https://github.com/pydata/xarray/pull/2467 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2467#event-1888659594, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1ooi7R3npC2m27npvMxbEgYbLyXjks5uiOO7gaJpZM4XLHP3 . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace the last of unittest with pytest 367410303
427582505 https://github.com/pydata/xarray/pull/2467#issuecomment-427582505 https://api.github.com/repos/pydata/xarray/issues/2467 MDEyOklzc3VlQ29tbWVudDQyNzU4MjUwNQ== max-sixty 5635139 2018-10-06T15:24:45Z 2018-10-06T15:24:45Z MEMBER

I added a commit to clear up some of the issues that @shoyer found.

Assuming tests pass, I'll merge shortly given risk of conflicts - please lmk any final comments. I'm also happy to do any flups after merge this weekend.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace the last of unittest with pytest 367410303
427535087 https://github.com/pydata/xarray/pull/2467#issuecomment-427535087 https://api.github.com/repos/pydata/xarray/issues/2467 MDEyOklzc3VlQ29tbWVudDQyNzUzNTA4Nw== pep8speaks 24736507 2018-10-06T01:16:03Z 2018-10-06T15:15:33Z NONE

Hello @max-sixty! Thanks for updating the PR.

Comment last updated on October 06, 2018 at 15:15 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace the last of unittest with pytest 367410303
427555865 https://github.com/pydata/xarray/pull/2467#issuecomment-427555865 https://api.github.com/repos/pydata/xarray/issues/2467 MDEyOklzc3VlQ29tbWVudDQyNzU1NTg2NQ== shoyer 1217238 2018-10-06T08:15:43Z 2018-10-06T08:15:43Z MEMBER

we can probably go ahead and safely merge this in its current state -- none of my comments are deal breakers

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace the last of unittest with pytest 367410303
427535714 https://github.com/pydata/xarray/pull/2467#issuecomment-427535714 https://api.github.com/repos/pydata/xarray/issues/2467 MDEyOklzc3VlQ29tbWVudDQyNzUzNTcxNA== max-sixty 5635139 2018-10-06T01:25:22Z 2018-10-06T01:25:22Z MEMBER

Is @pep8speaks respecting # noqa directions? It's still complaining about ambiguous variable names here: https://github.com/max-sixty/xarray/blob/pytest/xarray/tests/test_indexing.py#L27

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace the last of unittest with pytest 367410303

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);