issue_comments

Table actions

7 rows where issue = 362854704 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Documentation Review Request for Arviz · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
425613188 https://github.com/pydata/xarray/issues/2429#issuecomment-425613188 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNTYxMzE4OA== canyon289 7213793 2018-09-29T03:51:07Z 2018-09-29T03:51:07Z CONTRIBUTOR

Thank you for the additional feedback. It's been incorporated into a pull request

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
425483820 https://github.com/pydata/xarray/issues/2429#issuecomment-425483820 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNTQ4MzgyMA== shoyer 1217238 2018-09-28T16:02:36Z 2018-09-28T16:02:36Z MEMBER

Two minor comments: - "xarray" is the name of the package, not a particular type, so it's strange to read "an xarray" or "xarray". I would use an "xarray object" or "xarray dataset" instead. - If you're relying on netCDF4 groups, you might also mention that netCDF4 is built on top of HDF5, which many of your users may be familiar with from other contexts.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
425094439 https://github.com/pydata/xarray/issues/2429#issuecomment-425094439 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNTA5NDQzOQ== max-sixty 5635139 2018-09-27T13:34:29Z 2018-09-27T13:34:29Z MEMBER

OK!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
424953741 https://github.com/pydata/xarray/issues/2429#issuecomment-424953741 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNDk1Mzc0MQ== jhamman 2443309 2018-09-27T04:15:17Z 2018-09-27T04:15:17Z MEMBER

@max-sixty - Xarray when it used at the beginning of a sentence, otherwise just xarray. I must admit, I probably am not super consistent on this point though. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
424953125 https://github.com/pydata/xarray/issues/2429#issuecomment-424953125 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNDk1MzEyNQ== max-sixty 5635139 2018-09-27T04:12:36Z 2018-09-27T04:12:50Z MEMBER

Looks good @canyon289 !

I thought we'd decided to use Xarray rather than xarray, but our own docs have xarray throughout. @jhamman is my memory serving me poorly? I could do a find / replace on the docs if it's correct

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
424951442 https://github.com/pydata/xarray/issues/2429#issuecomment-424951442 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNDk1MTQ0Mg== canyon289 7213793 2018-09-27T04:03:00Z 2018-09-27T04:03:00Z CONTRIBUTOR

Great! I'll make the changes. Thank you very much for the feedback

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704
424947793 https://github.com/pydata/xarray/issues/2429#issuecomment-424947793 https://api.github.com/repos/pydata/xarray/issues/2429 MDEyOklzc3VlQ29tbWVudDQyNDk0Nzc5Mw== jhamman 2443309 2018-09-27T03:35:48Z 2018-09-27T03:35:48Z MEMBER

Thanks for sharing. Its nice to see xarray's being used in this way.

I gave your notebook a quick skim. I would suggest changing some of the nomenclature:

  • netcdf --> NetCDF
  • xarray.DataSet --> xarray.Dataset
  • Data Variables --> data variables

and a few possible typos:

  • In xarray terminology Data Variable --> In xarray's terminology, data variables
  • netcd documentation --> netcdf4-python documentation
  • netcd usage in xarray --> NetCDF usage in xarray
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation Review Request for Arviz 362854704

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);