issue_comments

Table actions

5 rows where issue = 360420464 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Indicate calendar type in CFTimeIndex repr · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
730739659 https://github.com/pydata/xarray/issues/2416#issuecomment-730739659 https://api.github.com/repos/pydata/xarray/issues/2416 MDEyOklzc3VlQ29tbWVudDczMDczOTY1OQ== spencerkclark 6628425 2020-11-20T01:00:41Z 2020-11-20T01:00:41Z MEMBER

@aaronspring I think that would be great. Indeed now that we have infer_freq it should be fairly straightforward; feel free to open a PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indicate calendar type in CFTimeIndex repr 360420464
730427143 https://github.com/pydata/xarray/issues/2416#issuecomment-730427143 https://api.github.com/repos/pydata/xarray/issues/2416 MDEyOklzc3VlQ29tbWVudDczMDQyNzE0Mw== aaronspring 12237157 2020-11-19T14:53:08Z 2020-11-19T14:53:08Z CONTRIBUTOR

using this feature now alot. @spencerkclark what about implementing also freq into the CFTimeIndex repr?

Its hard to see the frequency by eye sometimes, I would just rely on xr.infer_freq and add to the repr str, also if freq is None/indistinguishable

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indicate calendar type in CFTimeIndex repr 360420464
598466232 https://github.com/pydata/xarray/issues/2416#issuecomment-598466232 https://api.github.com/repos/pydata/xarray/issues/2416 MDEyOklzc3VlQ29tbWVudDU5ODQ2NjIzMg== spencerkclark 6628425 2020-03-12T22:49:46Z 2020-03-12T22:49:46Z MEMBER

Thanks @aaronspring -- I agree, it would be useful for CFTimeIndex to have a calendar type string attribute. I think you could probably leverage coding.times.infer_calendar_name within CFTimeIndex to determine its value. We'd be happy to take a PR.

You may also be aware that CFTimeIndex already has a date_type property, which can be useful on occasion. It returns the type of date used in the index, e.g. cftime.DatetimeNoLeap.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indicate calendar type in CFTimeIndex repr 360420464
598193427 https://github.com/pydata/xarray/issues/2416#issuecomment-598193427 https://api.github.com/repos/pydata/xarray/issues/2416 MDEyOklzc3VlQ29tbWVudDU5ODE5MzQyNw== aaronspring 12237157 2020-03-12T13:44:45Z 2020-03-12T13:44:45Z CONTRIBUTOR

would this be a starting point: https://github.com/pydata/xarray/blob/603b0ad3f8a02a9e1180eb8dfc72f7f885f0e19a/xarray/core/variable.py#L2222 ? but I dont see where calendar is coming from.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indicate calendar type in CFTimeIndex repr 360420464
598191749 https://github.com/pydata/xarray/issues/2416#issuecomment-598191749 https://api.github.com/repos/pydata/xarray/issues/2416 MDEyOklzc3VlQ29tbWVudDU5ODE5MTc0OQ== aaronspring 12237157 2020-03-12T13:41:13Z 2020-03-12T13:41:13Z CONTRIBUTOR

such a calendar attribute would be nice. Didnt find a workaround. My goal is to get a str for calendar type from ds:

Once implemented, this could then be accessed via ds.time.to_index().calendar. with some help where to start I would go for this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indicate calendar type in CFTimeIndex repr 360420464

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);