issue_comments

Table actions

4 rows where issue = 359935048 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

issue 1

  • add test for 1D object array indexing · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
813436072 https://github.com/pydata/xarray/pull/2415#issuecomment-813436072 https://api.github.com/repos/pydata/xarray/issues/2415 MDEyOklzc3VlQ29tbWVudDgxMzQzNjA3Mg== dcherian 2448579 2021-04-05T14:53:28Z 2021-04-05T14:53:28Z MEMBER

Thanks @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add test for 1D object array indexing 359935048
812920529 https://github.com/pydata/xarray/pull/2415#issuecomment-812920529 https://api.github.com/repos/pydata/xarray/issues/2415 MDEyOklzc3VlQ29tbWVudDgxMjkyMDUyOQ== max-sixty 5635139 2021-04-03T20:21:38Z 2021-04-03T20:21:38Z MEMBER

Let's do it! Thanks for resuscitating @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add test for 1D object array indexing 359935048
812888787 https://github.com/pydata/xarray/pull/2415#issuecomment-812888787 https://api.github.com/repos/pydata/xarray/issues/2415 MDEyOklzc3VlQ29tbWVudDgxMjg4ODc4Nw== keewis 14808389 2021-04-03T16:25:37Z 2021-04-03T16:25:37Z MEMBER

if we still want this test, it should be ready for review / merging

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add test for 1D object array indexing 359935048
421369237 https://github.com/pydata/xarray/pull/2415#issuecomment-421369237 https://api.github.com/repos/pydata/xarray/issues/2415 MDEyOklzc3VlQ29tbWVudDQyMTM2OTIzNw== shoyer 1217238 2018-09-14T14:05:47Z 2018-09-14T14:05:47Z MEMBER

You could pull it out with expected.data.item() On Fri, Sep 14, 2018 at 12:43 AM David Trémouilles notifications@github.com wrote:

@davidtrem commented on this pull request.

In xarray/tests/test_indexing.py https://github.com/pydata/xarray/pull/2415#discussion_r217625779:

@@ -622,3 +622,8 @@ def test_create_mask_error(): def test_posify_mask_subindexer(indices, expected): actual = indexing._posify_mask_subindexer(indices) np.testing.assert_array_equal(expected, actual) + + +def test_indexing_1d_object_array(): + testarray = DataArray(np.array((np.arange(3), np.arange(6)))) + testarray[0]

OK, I get you point :-) Main issue I still have then is that I'm not able to get the 'np.arange(3) array' from the 'expected'... because 'expected.data' is king of empty :-( expected.data.shape == () therefore expected.data[0] raise an IndexError How would you access the content of 'expected' ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2415#discussion_r217625779, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1uZNHXq96w2Dbt50Bw2uBHVxy00-ks5ua14TgaJpZM4Wnb0S . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   add test for 1D object array indexing 359935048

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);